fix: new cache entry check#8151
Merged
TkDodo merged 2 commits intoTanStack:mainfrom Oct 9, 2024
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 81ff334. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8151 +/- ##
===========================================
+ Coverage 45.41% 81.89% +36.48%
===========================================
Files 200 26 -174
Lines 7456 359 -7097
Branches 1696 98 -1598
===========================================
- Hits 3386 294 -3092
+ Misses 3694 56 -3638
+ Partials 376 9 -367
|
This was referenced Oct 31, 2024
Closed
This was referenced Nov 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wevm/wagmi#4322
Seems that #7988 introduced a subtle breaking change whereby the check for
isNewCacheEntrywould not account for a customqueryKeyHashFn. This is because the implementation ofgetQueryStatedoes not pass custom options from the query todefaultQueryOptions. As a result, this broke consumer code that relyed onqueryKeyHashFnto serialize bigints. This PR aims to access the cache directly withgetQueryCacheinstead.