fix(core): do not inform QueriesObserver subscribers if combined result hasn't changed by TkDodo · Pull Request #8153 · TanStack/query

TkDodo · 2024-10-09T12:46:52Z

…lt hasn't changed

nx-cloud · 2024-10-09T12:47:32Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f6fdbe2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

pkg-pr-new · 2024-10-09T12:49:26Z

Open in Stackblitz

More templates

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8153

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8153

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8153

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8153

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8153

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8153

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8153

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8153

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8153

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8153

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8153

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8153

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8153

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8153

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8153

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8153

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8153

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8153

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8153

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8153

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8153

commit: f6fdbe2

joel-narwhal · 2024-10-09T12:51:30Z

    client: QueryClient,
    queries: Array<QueryObserverOptions<any, any, any, any, any>>,
-    _options?: QueriesObserverOptions<TCombinedResult>,
+    options?: QueriesObserverOptions<TCombinedResult>,


Is it safe to rely on this? If options.combine change in the hook, will this be reflected?

yes because we update it here:

query/packages/query-core/src/queriesObserver.ts

Line 92 in f6fdbe2

this.#options = options

codecov · 2024-10-09T12:56:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.14%. Comparing base (2fe16e5) to head (f6fdbe2).
Report is 8 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8153       +/-   ##
===========================================
+ Coverage   45.41%   62.14%   +16.72%     
===========================================
  Files         200      136       -64     
  Lines        7456     4765     -2691     
  Branches     1696     1331      -365     
===========================================
- Hits         3386     2961      -425     
+ Misses       3694     1564     -2130     
+ Partials      376      240      -136

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`86.58% <ø> (ø)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`93.15% <100.00%> (+0.14%)`	⬆️
@tanstack/query-devtools	`4.79% <ø> (ø)`
@tanstack/query-persist-client-core	`57.73% <ø> (ø)`
@tanstack/query-sync-storage-persister	`82.50% <ø> (ø)`
@tanstack/react-query	`93.12% <100.00%> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.20% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`87.33% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.51% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

fix(core): do not inform QueriesObserver subscribers if combined resu…

f6fdbe2

…lt hasn't changed

github-actions Bot added package: react-query package: query-core labels Oct 9, 2024

joel-narwhal reviewed Oct 9, 2024

View reviewed changes

TkDodo merged commit cae2524 into main Oct 9, 2024

TkDodo deleted the feature/useQueries-re-render branch October 9, 2024 12:57

muhiddinjv mentioned this pull request Oct 31, 2024

[Snyk] Upgrade @tanstack/react-query from 5.45.1 to 5.59.8 muhiddinjv/ollio-app#113

Closed

Bancha-t mentioned this pull request Oct 31, 2024

[Snyk] Upgrade @tanstack/react-query from 5.59.0 to 5.59.8 Bancha-t/myweb#4

Open

Bonniemarie216 mentioned this pull request Oct 31, 2024

[Snyk] Upgrade @tanstack/react-query from 5.50.1 to 5.59.9 Bonniemarie216/seamless-interface#6

Open

This was referenced Nov 2, 2024

[Snyk] Upgrade @tanstack/react-query from 5.59.0 to 5.59.11 mong/mongts#3387

Closed

[Snyk] Upgrade @tanstack/react-query-devtools from 5.59.0 to 5.59.11 mong/mongts#3388

Closed

jwinr mentioned this pull request Nov 4, 2024

[Snyk] Upgrade @tanstack/react-query from 5.59.0 to 5.59.13 jwinr/threadly#31

Merged

CalPinSW mentioned this pull request Nov 5, 2024

[Snyk] Upgrade @tanstack/react-query from 5.53.1 to 5.59.13 CalPinSW/playlist-manager#55

Merged

GouravNG mentioned this pull request Nov 5, 2024

[Snyk] Upgrade @tanstack/react-query from 5.56.2 to 5.59.13 GouravNG/recipeland#22

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(core): do not inform QueriesObserver subscribers if combined result hasn't changed#8153

fix(core): do not inform QueriesObserver subscribers if combined result hasn't changed#8153
TkDodo merged 1 commit intomainfrom
feature/useQueries-re-render

TkDodo commented Oct 9, 2024

Uh oh!

nx-cloud Bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 9, 2024

Uh oh!

joel-narwhal Oct 9, 2024

Uh oh!

TkDodo Oct 9, 2024

Uh oh!

codecov Bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

TkDodo commented Oct 9, 2024

Uh oh!

nx-cloud Bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

pkg-pr-new Bot commented Oct 9, 2024

Uh oh!

joel-narwhal Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

TkDodo Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nx-cloud Bot commented Oct 9, 2024 •

edited

Loading

codecov Bot commented Oct 9, 2024 •

edited

Loading