fix(core): correctly gc query when suspense is used when query unmounts while it's still fetching#8168
Merged
fix(core): correctly gc query when suspense is used when query unmounts while it's still fetching#8168
Conversation
…ts while it's still fetching the `isFetchingOptimistic` workaround was added to make sure some "thing" I don't remember anymore works in suspense; we added tests for that; however, in the meantime, we added a minimum gcTime for suspense queries, which also solves that problem (tests still work); this makes the `isFetchingOptimistic` workaround unnecessary, and this workaround is actually what causes the unmount issue
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9812699. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8168 +/- ##
===========================================
+ Coverage 45.41% 62.09% +16.68%
===========================================
Files 200 136 -64
Lines 7456 4757 -2699
Branches 1696 1334 -362
===========================================
- Hits 3386 2954 -432
+ Misses 3694 1563 -2131
+ Partials 376 240 -136 |
This was referenced Nov 2, 2024
This was referenced Nov 7, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
isFetchingOptimisticworkaround was added to make sure some "thing" I don't remember anymore works in suspense; we added tests for that;however, in the meantime, we added a minimum gcTime for suspense queries, which also solves that problem (tests still work); this makes the
isFetchingOptimisticworkaround unnecessary, and this workaround is actually what causes the unmount issue.fixes #8159