fix: make queryFn optional again by juliusmarminge · Pull Request #8176 · TanStack/query

juliusmarminge · 2024-10-13T22:26:26Z

#8082 broke trpc's useSuspenseQueries as it made queryFn required. queryFn is optional in all other types and should remain so. We set this param internally and the users should not provide it themselves.

For example, this should be possible:

   const [posts] = client.useSuspenseQueries((t) => [
      t.post.byId(
        { id: '1' },
        {
          select(data) {
            return "bar" as const;
          },
        },
      ),
    ]);

most notably options doesn't have a queryFn specified since that's set by trpc internally.

this PR fixes the issue by making the override still optional, as it is in the base type

PR on trpc: trpc/trpc#6118 (see patch here: https://github.com/trpc/trpc/pull/6118/files#diff-996d92a63ec784c3182c4cfccc74574ce428ba741562b83cffa4fed1999539e1)

--

not sure how i should add tests in RQ for this

nx-cloud · 2024-10-13T22:26:58Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1fc90b7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

pkg-pr-new · 2024-10-13T22:28:27Z

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8176

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8176

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8176

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8176

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8176

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8176

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8176

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8176

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8176

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8176

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8176

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8176

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8176

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8176

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8176

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8176

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8176

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8176

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8176

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8176

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8176

commit: 1fc90b7

codecov · 2024-10-13T22:31:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (2fe16e5) to head (1fc90b7).
Report is 34 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8176       +/-   ##
===========================================
+ Coverage   45.41%   81.84%   +36.43%     
===========================================
  Files         200       26      -174     
  Lines        7456      358     -7098     
  Branches     1696       97     -1599     
===========================================
- Hits         3386      293     -3093     
+ Misses       3694       56     -3638     
+ Partials      376        9      -367

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/react-query	`93.10% <100.00%> (-0.03%)`	⬇️
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

make queryFn optional again

149eae8

juliusmarminge changed the title ~~make queryFn optional again~~ fix: make queryFn optional again Oct 13, 2024

github-actions Bot added the package: react-query label Oct 13, 2024

juliusmarminge mentioned this pull request Oct 13, 2024

chore: bump @tanstack/react-query dependency trpc/trpc#6118

Merged

more fix

1fc90b7

Saul-atomrigslab mentioned this pull request Oct 15, 2024

queryFn field became required in UseInfiniteQueryOptions #8180

Closed

TkDodo approved these changes Oct 15, 2024

View reviewed changes

TkDodo merged commit a085c92 into TanStack:main Oct 15, 2024

liam-russell mentioned this pull request Nov 6, 2024

[Snyk] Upgrade @tanstack/react-query from 5.59.13 to 5.59.15 liam-russell/liamr.co#2

Closed

This was referenced Nov 7, 2024

[Snyk] Upgrade @tanstack/react-query-persist-client from 5.56.1 to 5.59.15 zntb/crypto-ticker#69

Closed

[Snyk] Upgrade @tanstack/react-query from 5.59.8 to 5.59.15 zntb/crypto-ticker#71

Merged

muhiddinjv mentioned this pull request Nov 7, 2024

[Snyk] Upgrade @tanstack/react-query from 5.45.1 to 5.59.15 muhiddinjv/ollio-app#117

Closed

doperiddle mentioned this pull request Nov 8, 2024

[Snyk] Upgrade @tanstack/react-query from 5.18.1 to 5.59.15 doperiddle/web-examples#10

Merged

snyk-io Bot mentioned this pull request Nov 9, 2024

[Snyk] Upgrade @tanstack/react-query from 4.19.1 to 5.59.15 doperiddle/chainlist#6

Closed

muhammadahsanmirza mentioned this pull request Nov 10, 2024

[Snyk] Upgrade @tanstack/react-query from 5.54.1 to 5.59.15 muhammadahsanmirza/internship-portal-client-view#7

Open

JulianFl mentioned this pull request Nov 10, 2024

[Snyk] Upgrade @tanstack/react-query from 5.32.1 to 5.59.15 JulianFl/PicturaObscura#21

Open

haesoo-y mentioned this pull request Feb 26, 2025

chore(react-query): add warning when useSuspenseQuery is used without queryFn #8700

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: make queryFn optional again#8176

fix: make queryFn optional again#8176
TkDodo merged 2 commits intoTanStack:mainfrom
juliusmarminge:optional-queryFn

juliusmarminge commented Oct 13, 2024 •

edited by TkDodo

Loading

Uh oh!

nx-cloud Bot commented Oct 13, 2024 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 13, 2024 •

edited

Loading

Uh oh!

codecov Bot commented Oct 13, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

juliusmarminge commented Oct 13, 2024 • edited by TkDodo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud Bot commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

pkg-pr-new Bot commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

juliusmarminge commented Oct 13, 2024 •

edited by TkDodo

Loading

nx-cloud Bot commented Oct 13, 2024 •

edited

Loading

pkg-pr-new Bot commented Oct 13, 2024 •

edited

Loading

codecov Bot commented Oct 13, 2024 •

edited

Loading