Remove predicate typing for query filters#8958
Merged
TkDodo merged 5 commits intoTanStack:mainfrom Apr 14, 2025
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 209af08.
☁️ Nx Cloud last updated this comment at |
Contributor
Author
|
So @TkDodo I'm in two minds if we should go as far as stripping out the generics entirely. It's more of a breaking change to remove them than to leave them unused, especially since the 4th type param (query key) does get used currently. What do you think? |
Collaborator
|
TypeScript errors on unused type parameters: so what option do we have other than deleting them? |
Contributor
Author
|
Should be possible to ignore the warnings I think? So it's more a question of where your mind is at as a maintainer I didn't do anything today beyond start this draft, there will be tests failing as well that I can sort out either way |
Collaborator
this isn’t just an eslint warning - it’s a TS error that you would need to silence with |
Nick-Lucas
force-pushed
the
remove-typesafe-query-filters
branch
from
84eb7d3 to
8064c84
Compare
Nick-Lucas
changed the title
Contributor
Author
|
Hey @TkDodo I've stripped this out everywhere, might need synchronising with tRPC as I think we made some changes to support these generics but that should be quick |
3 tasks
Contributor
Author
|
failing test seems to be flake rather than anything I've done, could use a retry |
TkDodo
approved these changes
Apr 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8958 +/- ##
===========================================
+ Coverage 44.47% 59.01% +14.54%
===========================================
Files 203 138 -65
Lines 8104 5358 -2746
Branches 1804 1424 -380
===========================================
- Hits 3604 3162 -442
+ Misses 4066 1907 -2159
+ Partials 434 289 -145 🚀 New features to boost your workflow:
|
1 task
juliusmarminge
added a commit
to trpc/trpc
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes #6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-next-formdata
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes trpc/trpc#6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-next-big-router
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes trpc/trpc#6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-minimal-react
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes trpc/trpc#6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-next-app-dir
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes trpc/trpc#6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-next-minimal-starter
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes trpc/trpc#6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-next-prisma-websockets-starter
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes trpc/trpc#6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-next-prisma-starter
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes trpc/trpc#6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-next-prisma-todomvc
that referenced
this pull request
Apr 29, 2025
Affected by TanStack/query#8958 Closes trpc/trpc#6730 ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary, I have added documentation related to the changes made. - [ ] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined internal query filtering methods by simplifying filter type parameters, improving usability and clarity. - **Chores** - Upgraded the core query library dependency across the project and examples to version `^5.74.7`, enhancing performance, stability, and access to the latest features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <jmarminge@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8768