Skip to content

test(vue-query): remove unnecessary async #9028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 1 commit into from
Apr 17, 2025
Merged

test(vue-query): remove unnecessary async #9028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vue-query/src/__tests__/mutationCache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe('MutationCache', () => {
})

describe('find', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const mutationCache = new MutationCache()

mutationCache.find({
Expand All @@ -24,7 +24,7 @@ describe('MutationCache', () => {
})

describe('findAll', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const mutationCache = new MutationCache()

mutationCache.findAll({
Expand Down
6 changes: 3 additions & 3 deletions packages/vue-query/src/__tests__/queryCache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe('QueryCache', () => {
})

describe('find', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const queryCache = new QueryCache()

queryCache.find({
Expand All @@ -24,7 +24,7 @@ describe('QueryCache', () => {
})

describe('findAll', () => {
test('should properly unwrap two parameters', async () => {
test('should properly unwrap two parameters', () => {
const queryCache = new QueryCache()

queryCache.findAll({
Expand All @@ -36,7 +36,7 @@ describe('QueryCache', () => {
})
})

test('should default to empty filters', async () => {
test('should default to empty filters', () => {
const queryCache = new QueryCache()

queryCache.findAll()
Expand Down
46 changes: 23 additions & 23 deletions packages/vue-query/src/__tests__/queryClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const fn = () => 'mock'

describe('QueryCache', () => {
describe('isFetching', () => {
test('should properly unwrap 1 parameter', async () => {
test('should properly unwrap 1 parameter', () => {
const queryClient = new QueryClient()

queryClient.isFetching({
Expand All @@ -28,7 +28,7 @@ describe('QueryCache', () => {
})

describe('isMutating', () => {
test('should properly unwrap 1 parameter', async () => {
test('should properly unwrap 1 parameter', () => {
const queryClient = new QueryClient()

queryClient.isMutating({
Expand All @@ -42,7 +42,7 @@ describe('QueryCache', () => {
})

describe('getQueryData', () => {
test('should properly unwrap 1 parameter', async () => {
test('should properly unwrap 1 parameter', () => {
const queryClient = new QueryClient()

queryClient.getQueryData(queryKeyRef)
Expand All @@ -54,7 +54,7 @@ describe('QueryCache', () => {
})

describe('getQueriesData', () => {
test('should properly unwrap queryKey param', async () => {
test('should properly unwrap queryKey param', () => {
const queryClient = new QueryClient()

queryClient.getQueriesData({ queryKey: queryKeyRef })
Expand All @@ -64,7 +64,7 @@ describe('QueryCache', () => {
})
})

test('should properly unwrap filters param', async () => {
test('should properly unwrap filters param', () => {
const queryClient = new QueryClient()

queryClient.getQueriesData({ queryKey: queryKeyRef })
Expand All @@ -76,7 +76,7 @@ describe('QueryCache', () => {
})

describe('setQueryData', () => {
test('should properly unwrap 3 parameter', async () => {
test('should properly unwrap 3 parameter', () => {
const queryClient = new QueryClient()

queryClient.setQueryData(queryKeyRef, fn, {
Expand All @@ -92,7 +92,7 @@ describe('QueryCache', () => {
})

describe('setQueriesData', () => {
test('should properly unwrap params with queryKey', async () => {
test('should properly unwrap params with queryKey', () => {
const queryClient = new QueryClient()

queryClient.setQueriesData({ queryKey: queryKeyRef }, fn, {
Expand All @@ -106,7 +106,7 @@ describe('QueryCache', () => {
)
})

test('should properly unwrap params with filters', async () => {
test('should properly unwrap params with filters', () => {
const queryClient = new QueryClient()

queryClient.setQueriesData({ queryKey: queryKeyRef }, fn, {
Expand All @@ -122,7 +122,7 @@ describe('QueryCache', () => {
})

describe('getQueryState', () => {
test('should properly unwrap 1 parameter', async () => {
test('should properly unwrap 1 parameter', () => {
const queryClient = new QueryClient()

queryClient.getQueryState(queryKeyRef)
Expand All @@ -134,7 +134,7 @@ describe('QueryCache', () => {
})

describe('removeQueries', () => {
test('should properly unwrap 1 parameter', async () => {
test('should properly unwrap 1 parameter', () => {
const queryClient = new QueryClient()

queryClient.removeQueries({
Expand All @@ -148,7 +148,7 @@ describe('QueryCache', () => {
})

describe('resetQueries', () => {
test('should properly unwrap 2 parameter', async () => {
test('should properly unwrap 2 parameter', () => {
const queryClient = new QueryClient()

queryClient.resetQueries(
Expand All @@ -168,7 +168,7 @@ describe('QueryCache', () => {
})

describe('cancelQueries', () => {
test('should properly unwrap 2 parameter', async () => {
test('should properly unwrap 2 parameter', () => {
const queryClient = new QueryClient()

queryClient.cancelQueries(
Expand Down Expand Up @@ -259,7 +259,7 @@ describe('QueryCache', () => {
})

describe('refetchQueries', () => {
test('should properly unwrap 2 parameter', async () => {
test('should properly unwrap 2 parameter', () => {
const queryClient = new QueryClient()

queryClient.refetchQueries(
Expand All @@ -279,7 +279,7 @@ describe('QueryCache', () => {
})

describe('fetchQuery', () => {
test('should properly unwrap parameter', async () => {
test('should properly unwrap parameter', () => {
const queryClient = new QueryClient()

queryClient.fetchQuery({
Expand All @@ -293,7 +293,7 @@ describe('QueryCache', () => {
})

describe('prefetchQuery', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const queryClient = new QueryClient()

queryClient.prefetchQuery({ queryKey: queryKeyRef, queryFn: fn })
Expand All @@ -306,7 +306,7 @@ describe('QueryCache', () => {
})

describe('fetchInfiniteQuery', () => {
test('should properly unwrap parameter', async () => {
test('should properly unwrap parameter', () => {
const queryClient = new QueryClient()

queryClient.fetchInfiniteQuery({
Expand All @@ -319,7 +319,7 @@ describe('QueryCache', () => {
queryKey: queryKeyUnref,
})
})
test('should properly unwrap parameter using infiniteQueryOptions with unref', async () => {
test('should properly unwrap parameter using infiniteQueryOptions with unref', () => {
const queryClient = new QueryClient()

const options = infiniteQueryOptions({
Expand All @@ -338,7 +338,7 @@ describe('QueryCache', () => {
})

describe('prefetchInfiniteQuery', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const queryClient = new QueryClient()

queryClient.prefetchInfiniteQuery({
Expand All @@ -356,7 +356,7 @@ describe('QueryCache', () => {
})

describe('setDefaultOptions', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const queryClient = new QueryClient()

queryClient.setDefaultOptions({
Expand All @@ -374,7 +374,7 @@ describe('QueryCache', () => {
})

describe('setQueryDefaults', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const queryClient = new QueryClient()

queryClient.setQueryDefaults(queryKeyRef, {
Expand All @@ -391,7 +391,7 @@ describe('QueryCache', () => {
})

describe('getQueryDefaults', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const queryClient = new QueryClient()

queryClient.getQueryDefaults(queryKeyRef)
Expand All @@ -403,7 +403,7 @@ describe('QueryCache', () => {
})

describe('setMutationDefaults', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const queryClient = new QueryClient()

queryClient.setMutationDefaults(queryKeyRef, {
Expand All @@ -420,7 +420,7 @@ describe('QueryCache', () => {
})

describe('getMutationDefaults', () => {
test('should properly unwrap parameters', async () => {
test('should properly unwrap parameters', () => {
const queryClient = new QueryClient()

queryClient.getMutationDefaults(queryKeyRef)
Expand Down
4 changes: 2 additions & 2 deletions packages/vue-query/src/__tests__/useIsMutating.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ describe('useIsMutating', () => {
})

describe('useMutationState', () => {
it('should return variables after calling mutate 1', async () => {
it('should return variables after calling mutate 1', () => {
const mutationKey = ['mutation']
const variables = 'foo123'

Expand All @@ -102,7 +102,7 @@ describe('useMutationState', () => {
expect(mutationState.value).toEqual([variables])
})

it('should return variables after calling mutate 2', async () => {
it('should return variables after calling mutate 2', () => {
const queryClient = useQueryClient()
queryClient.clear()
const mutationKey = ['mutation']
Expand Down
Loading