Skip to content

refactor(query-async-storage-persister): remove unnecessary export "AsyncThrottleOptions"#9040

Merged
TkDodo merged 1 commit intoTanStack:mainfrom
minseong0324:refactor/unnecssary-export-query-async-storage-persister
Apr 19, 2025
Merged

refactor(query-async-storage-persister): remove unnecessary export "AsyncThrottleOptions"#9040
TkDodo merged 1 commit intoTanStack:mainfrom
minseong0324:refactor/unnecssary-export-query-async-storage-persister

Conversation

@minseong0324
Copy link
Copy Markdown
Contributor

@minseong0324 minseong0324 commented Apr 18, 2025 •
edited
Loading

AsyncThrottleOptions are only used within asyncThrottle.ts, so I decided that it would be better not to export them.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bda2404.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 16s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-18 19:58:10 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 18, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9040

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9040

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9040

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9040

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9040

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9040

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9040

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9040

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9040

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9040

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9040

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9040

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9040

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9040

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9040

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9040

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9040

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9040

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9040

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9040

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9040

commit: bda2404

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.85%. Comparing base (b6faa37) to head (bda2404).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9040      +/-   ##
==========================================
- Coverage   44.58%   43.85%   -0.73%     
==========================================
  Files         203        3     -200     
  Lines        8106       57    -8049     
  Branches     1803       11    -1792     
==========================================
- Hits         3614       25    -3589     
+ Misses       4060       28    -4032     
+ Partials      432        4     -428
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo
Copy link
Copy Markdown
Collaborator

TkDodo commented Apr 19, 2025

knip should find this. The fact that it doesn’t means something is setup wrongly with knip :/

@TkDodo TkDodo merged commit b63a1d0 into TanStack:main Apr 19, 2025
7 checks passed
@minseong0324
Copy link
Copy Markdown
Contributor Author

minseong0324 commented Apr 20, 2025 •
edited
Loading

knip should find this. The fact that it doesn’t means something is setup wrongly with knip :/

@TkDodo Since knip didn’t catch these unused exports, it seems like there might be a config issue.
Would it make sense to open an issue to track this?

@TkDodo
Copy link
Copy Markdown
Collaborator

TkDodo commented Apr 20, 2025

yeah, if you want to take a look at it, please do 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: query-async-storage-persister

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@minseong0324 @TkDodo