ci(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually by manudeli · Pull Request #9104 · TanStack/query

manudeli · 2025-05-05T13:25:06Z

No description provided.

…' rule as error across multiple packages gradually

nx-cloud · 2025-05-05T13:25:32Z

View your CI Pipeline Execution ↗ for commit 7018138.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 47s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 45s	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 08:13:58 UTC

manudeli · 2025-05-05T13:25:48Z

-    rules: {
-      ...vitest.configs.recommended.rules,
-      'vitest/expect-expect': 'warn',
-    },


Initiate eslint vitest/expect-expect as error for all package

pkg-pr-new · 2025-05-05T13:34:35Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9104

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9104

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9104

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9104

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9104

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9104

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9104

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9104

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9104

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9104

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9104

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9104

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9104

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9104

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9104

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9104

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9104

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9104

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9104

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9104

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9104

commit: 7018138

…oss multiple packages

codecov · 2025-05-05T14:19:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.50%. Comparing base (127bd01) to head (7018138).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9104   +/-   ##
=======================================
  Coverage   44.50%   44.50%           
=======================================
  Files         204      204           
  Lines        8150     8150           
  Branches     1819     1827    +8     
=======================================
  Hits         3627     3627           
  Misses       4080     4080           
  Partials      443      443

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`85.04% <ø> (ø)`
@tanstack/eslint-plugin-query	`83.02% <ø> (ø)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`24.39% <ø> (ø)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`95.96% <ø> (ø)`
@tanstack/query-devtools	`3.61% <ø> (ø)`
@tanstack/query-persist-client-core	`73.46% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/react-query	`95.42% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.48% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.15% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.10% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chore(*): init ESLint configurations to include 'vitest/expect-expect…

8f4c6cf

…' rule as error across multiple packages gradually

github-actions Bot added package: react-query-devtools package: react-query package: react-query-persist-client package: vue-query labels May 5, 2025

manudeli changed the title ~~chore(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually~~ ci(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually May 5, 2025

manudeli commented May 5, 2025

View reviewed changes

chore(query-core): remove unused import from ESLint configuration

6dade4e

manudeli added 2 commits May 5, 2025 22:35

chore(angular-query-experimental): update eslint rule

8672a4d

chore: integrate vitest ESLint plugin and apply recommended rules acr…

f9a5e53

…oss multiple packages

github-actions Bot added the package: eslint-plugin-query label May 5, 2025

chore(react-query-devtools): add vitest ESLint plugin to configuration

6e9b756

manudeli added 2 commits May 6, 2025 06:21

Merge branch 'main' into test/eslint-vitest-plugin-expect-expect

9aaf893

Merge branch 'main' into test/eslint-vitest-plugin-expect-expect

7018138

manudeli marked this pull request as ready for review May 6, 2025 08:11

manudeli merged commit 0943575 into TanStack:main May 6, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually#9104

ci(*): init ESLint configurations to include 'vitest/expect-expect' rule as error across multiple packages gradually#9104
manudeli merged 7 commits intoTanStack:mainfrom
manudeli:test/eslint-vitest-plugin-expect-expect

manudeli commented May 5, 2025

Uh oh!

nx-cloud Bot commented May 5, 2025 •

edited

Loading

Uh oh!

manudeli May 5, 2025

Uh oh!

pkg-pr-new Bot commented May 5, 2025 •

edited

Loading

Uh oh!

codecov Bot commented May 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

manudeli commented May 5, 2025

Uh oh!

nx-cloud Bot commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manudeli May 5, 2025

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nx-cloud Bot commented May 5, 2025 •

edited

Loading

pkg-pr-new Bot commented May 5, 2025 •

edited

Loading

codecov Bot commented May 5, 2025 •

edited

Loading