Skip to content

test(react-query): improve branch coverage for useSuspenseQuery skipToken error handling#9112

Merged
manudeli merged 6 commits intoTanStack:mainfrom
SEOKKAMONI:test/use-suspense-query
May 7, 2025
Merged

test(react-query): improve branch coverage for useSuspenseQuery skipToken error handling#9112
manudeli merged 6 commits intoTanStack:mainfrom
SEOKKAMONI:test/use-suspense-query

Conversation

@SEOKKAMONI
Copy link
Copy Markdown
Contributor

@SEOKKAMONI SEOKKAMONI commented May 7, 2025

improve branch coverage for useSuspenseQuery skipToken error handling

AS-IS

스크린샷 2025-05-07 오후 10 05 48

TO-BE

스크린샷 2025-05-07 오후 10 05 32

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9f62187.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 28s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 35s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-07 17:42:13 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9112

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9112

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9112

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9112

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9112

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9112

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9112

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9112

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9112

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9112

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9112

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9112

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9112

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9112

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9112

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9112

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9112

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9112

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9112

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9112

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9112

commit: 9f62187

@SEOKKAMONI SEOKKAMONI marked this pull request as draft May 7, 2025 13:13
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (b1cdbc3) to head (9f62187).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9112       +/-   ##
===========================================
+ Coverage   44.55%   84.22%   +39.67%     
===========================================
  Files         207       26      -181     
  Lines        8159      374     -7785     
  Branches     1830      110     -1720     
===========================================
- Hits         3635      315     -3320     
+ Misses       4081       50     -4031     
+ Partials      443        9      -434
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SEOKKAMONI SEOKKAMONI marked this pull request as ready for review May 7, 2025 13:19
manudeli
manudeli approved these changes May 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manudeli manudeli merged commit 2a62ea1 into TanStack:main May 7, 2025
7 checks passed
minseong0324 pushed a commit to minseong0324/Tanstack-query that referenced this pull request May 7, 2025
@SEOKKAMONI @manudeli @minseong0324
test(react-query): improve branch coverage for useSuspenseQuery skipT…
c9af883 
…oken error handling (TanStack#9112)

Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manudeli manudeli manudeli approved these changes

Assignees

No one assigned

Labels

package: react-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SEOKKAMONI @manudeli