chore: add typescript-eslint/require-await rule by manudeli · Pull Request #9116 · TanStack/query

manudeli · 2025-05-07T19:38:31Z

No description provided.

Co-authored-by: MINSEONG KIM <65233075+minseong0324@users.noreply.github.com>

…undant require-await rule

nx-cloud · 2025-05-07T19:38:59Z

View your CI Pipeline Execution ↗ for commit 982e271.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 21s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-07 19:47:15 UTC

pkg-pr-new · 2025-05-07T19:41:57Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9116

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9116

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9116

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9116

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9116

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9116

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9116

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9116

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9116

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9116

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9116

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9116

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9116

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9116

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9116

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9116

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9116

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9116

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9116

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9116

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9116

commit: 982e271

manudeli · 2025-05-07T19:42:15Z

    rules: {
      'cspell/spellchecker': 'off',
      '@typescript-eslint/no-unnecessary-condition': 'off',
+      '@typescript-eslint/require-await': 'off',


@minseong0324 I'm going to treat it like this now.

We can apply @typescript-eslint/require-await rule as error to the rest by turning off the this rule only for @tanstack/query-codemods

codecov · 2025-05-07T19:49:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (2a62ea1) to head (982e271).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9116   +/-   ##
=======================================
  Coverage   44.55%   44.55%           
=======================================
  Files         207      207           
  Lines        8159     8159           
  Branches     1829     1829           
=======================================
  Hits         3635     3635           
  Misses       4081     4081           
  Partials      443      443

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`85.04% <ø> (ø)`
@tanstack/eslint-plugin-query	`83.02% <ø> (ø)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`24.39% <ø> (ø)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`96.14% <ø> (ø)`
@tanstack/query-devtools	`3.61% <ø> (ø)`
@tanstack/query-persist-client-core	`73.46% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/query-test-utils	`77.77% <ø> (ø)`
@tanstack/react-query	`95.42% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`77.84% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.15% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.10% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: MINSEONG KIM <65233075+minseong0324@users.noreply.github.com>

manudeli and others added 3 commits May 8, 2025 02:53

chore: add typescript-eslint/require-await rule

c4af51c

Co-authored-by: MINSEONG KIM <65233075+minseong0324@users.noreply.github.com>

ci(*): add ESLint rule require-await

4404f76

Co-authored-by: MINSEONG KIM <65233075+minseong0324@users.noreply.github.com>

refactor(eslint): simplify vitest rules configuration by removing red…

5bf1a82

…undant require-await rule

github-actions Bot added package: react-query package: query-core package: angular-query-experimental package: query-codemods package: query-broadcast-client-experimental labels May 7, 2025

chore: udpate

982e271

manudeli commented May 7, 2025

View reviewed changes

manudeli marked this pull request as ready for review May 7, 2025 19:48

manudeli merged commit 66ea5f2 into TanStack:main May 7, 2025
5 checks passed

minseong0324 added a commit to minseong0324/Tanstack-query that referenced this pull request May 7, 2025

chore: add typescript-eslint/require-await rule (TanStack#9116)

4642b5b

Co-authored-by: MINSEONG KIM <65233075+minseong0324@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: add typescript-eslint/require-await rule #9116

chore: add typescript-eslint/require-await rule #9116
manudeli merged 4 commits intoTanStack:mainfrom
manudeli:chore/ts-async-lint-rules

manudeli commented May 7, 2025

Uh oh!

nx-cloud Bot commented May 7, 2025 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 7, 2025 •

edited

Loading

Uh oh!

manudeli May 7, 2025

Uh oh!

Uh oh!

codecov Bot commented May 7, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

manudeli commented May 7, 2025

Uh oh!

nx-cloud Bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manudeli May 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nx-cloud Bot commented May 7, 2025 •

edited

Loading

pkg-pr-new Bot commented May 7, 2025 •

edited

Loading

codecov Bot commented May 7, 2025 •

edited

Loading