Skip to content

test(query-core/infiniteQueryObserver): remove duplicate 'InfiniteQueryObserver' and fix grammar in test names #9332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manudeli merged 3 commits into from
Jul 1, 2025
Merged

test(query-core/infiniteQueryObserver): remove duplicate 'InfiniteQueryObserver' and fix grammar in test names #9332

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b273fd
test(query-core/infiniteQueryObserver): remove duplicate 'InfiniteQue…
sukvvon Jun 29, 2025
1165263
Merge branch 'main' into test/query-core-infiniteQueryObserver-fix-te…
sukvvon Jun 29, 2025
bb1ffbc
Merge branch 'main' into test/query-core-infiniteQueryObserver-fix-te…
manudeli Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/query-core/src/__tests__/infiniteQueryObserver.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('InfiniteQueryObserver', () => {
vi.useRealTimers()
})

test('InfiniteQueryObserver should be able to fetch an infinite query with selector', async () => {
test('should be able to fetch an infinite query with selector', async () => {
const key = queryKey()
const observer = new InfiniteQueryObserver(queryClient, {
queryKey: key,
Expand All @@ -43,7 +43,7 @@ describe('InfiniteQueryObserver', () => {
})
})

test('InfiniteQueryObserver should pass the meta option to the queryFn', async () => {
test('should pass the meta option to the queryFn', async () => {
const meta = {
it: 'works',
}
Expand Down Expand Up @@ -73,7 +73,7 @@ describe('InfiniteQueryObserver', () => {
expect(queryFn).toBeCalledWith(expect.objectContaining({ meta }))
})

test('getNextPagParam and getPreviousPageParam should receive current pageParams', async () => {
test('should make getNextPageParam and getPreviousPageParam receive current pageParams', async () => {
const key = queryKey()
let single: Array<string> = []
let all: Array<string> = []
Expand Down Expand Up @@ -207,7 +207,7 @@ describe('InfiniteQueryObserver', () => {
expect(observer.getCurrentResult().hasNextPage).toBe(false)
})

test('getOptimisticResult should set infinite query behavior and return initial state', () => {
test('should set infinite query behavior via getOptimisticResult and return the initial state', () => {
const key = queryKey()
const observer = new InfiniteQueryObserver(queryClient, {
queryKey: key,
Expand Down
Loading