Skip to content

test(react-query/useMutationState): clarify assertions and improve code formatting #9611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 2 commits into from
Sep 3, 2025
Merged

test(react-query/useMutationState): clarify assertions and improve code formatting #9611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84f819e
test(react-query/useMutationState): clarify assertions and improve co…
sukvvon Sep 2, 2025
79b9ebf
Merge branch 'main' into test/react-query-use-mutation-state-clarify-…
sukvvon Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions packages/react-query/src/__tests__/useMutationState.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ describe('useIsMutating', () => {

function IsMutating() {
const isMutating = useIsMutating()

isMutatingArray.push(isMutating)

return null
}

Expand Down Expand Up @@ -52,6 +54,7 @@ describe('useIsMutating', () => {
}

const rendered = renderWithClient(queryClient, <Page />)

fireEvent.click(rendered.getByRole('button', { name: /mutate1/i }))
await vi.advanceTimersByTimeAsync(10)
fireEvent.click(rendered.getByRole('button', { name: /mutate2/i }))
Expand All @@ -62,12 +65,14 @@ describe('useIsMutating', () => {
// [ +0, 1, 2, 1, +0 ]
// our batching strategy might yield different results

await vi.advanceTimersByTimeAsync(40)
await vi.advanceTimersByTimeAsync(41)
expect(isMutatingArray[0]).toEqual(0)
expect(isMutatingArray[1]).toEqual(1)
expect(isMutatingArray[2]).toEqual(2)
await vi.advanceTimersByTimeAsync(1)
expect(isMutatingArray[isMutatingArray.length - 1]).toEqual(0)
expect(isMutatingArray[3]).toEqual(1)
expect(isMutatingArray[4]).toEqual(0)

expect(isMutatingArray).toEqual([0, 1, 2, 1, 0])
})

it('should filter correctly by mutationKey', async () => {
Expand Down Expand Up @@ -99,6 +104,7 @@ describe('useIsMutating', () => {
}

renderWithClient(queryClient, <Page />)

await vi.advanceTimersByTimeAsync(101)
expect(isMutatingArray).toEqual([0, 1, 0])
})
Expand Down Expand Up @@ -135,6 +141,7 @@ describe('useIsMutating', () => {
}

renderWithClient(queryClient, <Page />)

await vi.advanceTimersByTimeAsync(101)
expect(isMutatingArray).toEqual([0, 1, 0])
})
Expand Down Expand Up @@ -163,7 +170,7 @@ describe('useIsMutating', () => {
)
}

const rendered = render(<Page></Page>)
const rendered = render(<Page />)

await vi.advanceTimersByTimeAsync(0)
expect(rendered.getByText('mutating: 1')).toBeInTheDocument()
Expand Down Expand Up @@ -220,12 +227,11 @@ describe('useMutationState', () => {

const rendered = renderWithClient(queryClient, <Page />)

rendered.getByText('data: null')
expect(rendered.getByText('data: null')).toBeInTheDocument()

fireEvent.click(rendered.getByRole('button', { name: /mutate/i }))

await vi.advanceTimersByTimeAsync(151)
rendered.getByText('data: data1')
expect(rendered.getByText('data: data1')).toBeInTheDocument()

expect(variables).toEqual([[], [1], []])
})
Expand Down
Loading