Weird typings in server functions

[arackaf]

Which project does this relate to?

Start

Describe the bug

Type system does not seem to live primitives being returned from validator.

Code is below. Returning the literal 12 from validator results in ctx.data being any. as const does not change that. Interestingly, as number does get the typing correct.

import { createFileRoute, Link } from "@tanstack/react-router";
import { createServerFn } from "@tanstack/start";

export const serverFn1 = createServerFn({ method: "GET" })
  .validator((x: string) => {
    return 12;
  })
  .handler((ctx) => {
    const x = ctx.data; // x is any
    return { time: "" };
  });

export const serverFn2 = createServerFn({ method: "GET" })
  .validator((x: string) => {
    return 12 as const;
  })
  .handler((ctx) => {
    const x = ctx.data; // x is any
    return { time: "" };
  });

export const Route = createFileRoute("/")({
  component: Home,
  async loader() {
    return {};
  },
});

function Home() {
  return (
    <div>
      <Link to="/foo">Foo</Link>
      <div>Hello</div>
    </div>
  );
}

Your Example Website or App

https://github.com/arackaf/tanstack-start-test-1/blob/special/typings-weird-issue/app/routes/index.tsx

Steps to Reproduce the Bug or Issue

Clone and install from the repo above, look at the file linked above, lines 9 and 18

Expected behavior

x should be number

Screenshots or Videos

No response

Platform

n/a

Additional context

No response

[schiller-manuel]

still valid?

[arackaf]

Definitely

[arackaf]

@schiller-manuel so sorry - when I answered I was thinking about the other issue I opened related to middleware typings.

I'll try to fire this back up, update and test again

[chorobin]

This should be fixed by #4032

@arackaf Is it now how you expect this to work so we can close it off?

[arackaf]

@chorobin I'm sure it is - I've honestly no clue where this code is for me to even repro - I'd just close!