Skip to content

Conversation

@a-maas
Copy link
Contributor

@a-maas a-maas commented May 4, 2024

fixes #1550.

Based on the issue, I was experiencing issues with the vite plugin generation not working when using a non-standard vite root configuration. This was caused by a mismatch between most of the code using ./ or process.cwd() as the relative root, and this line using vite.root.

I don't think vite's root config is strictly necessary here, because the TSR configuration already allows you to configure your routesDirectory and generatedRouteTree if using a non-standard directory structure.

@nx-cloud
Copy link

nx-cloud bot commented May 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a12eca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@SeanCassiere SeanCassiere changed the title fix: use cwd instead of vite.root for vite plugin fix(router-vite-plugin): use cwd instead of vite.root May 4, 2024
@schiller-manuel schiller-manuel merged commit fda1559 into TanStack:main May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vite Plugin not re-generating routes with a non-standard Vite root configured

2 participants