fix(react-router): ResolvedSuspense to always use React.Suspense never the SafeFragment

[mta-trackunit]

If you create any hook that relies on a tanstack router hook - it becomes hard to test since the rerender recreates the elements again, I traced it down to this part in matches.tsx
const ResolvedSuspense = !router.state.matches.length ? React.Suspense : SafeFragment
It makes state changes with only the React.Suspense it works, dont really know if its intended or not? if so please explain how we could get around it for testing.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8164183. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 2 targets

• nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
• nx run-many --target=build --exclude=examples/**

---

Sent with 💌 from NxCloud.

[pkg-pr-new]

commit: 8164183

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@1822

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@1822

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@1822

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@1822

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@1822

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@1822

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@1822

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@1822

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@1822

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@1822

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@1822

Open in Stackblitz

More templates

• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-file-based-codesplitting
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• tanstack-router-react-example-scroll-restoration
• tanstack-router-example-react-start-basic
• tanstack-router-example-react-start-basic-counter
• tanstack-router-example-react-start-basic-react-query
• tanstack-router-example-react-start-basic-rsc
• tanstack-router-example-react-start-trello-trellaux
• tanstack-router-example-react-start-basic-trellaux
• tanstack-router-react-example-with-trpc-react-query
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc

[mta-trackunit]

@SeanCassiere how come you removed the
history: createMemoryHistory({ initialEntries: ['/'] }),

[mta-trackunit]

@SeanCassiere I believe this is ready for release now?

[SeanCassiere]

@SeanCassiere how come you removed the history: createMemoryHistory({ initialEntries: ['/'] }),

Mostly so we emulate the other tests and use the browser history.

[SeanCassiere]

As mentioned in this discord thread, I've tested this locally with the basic, basic-file-based, kitchen-sink-file-based, and start-basic examples, and I have observed no visible regressions.

@schiller-manuel @tannerlinsley anything blocking this from your side?

[mta-trackunit]

As mentioned in this discord thread, I've tested this locally with the basic, basic-file-based, kitchen-sink-file-based, and start-basic examples, and I have observed no visible regressions.

@schiller-manuel @tannerlinsley anything blocking this from your side?

you are linking to a private channel - so I cannot follow along :) - any update?