feat(router-devtools-core): add navigation link to route#4048
Merged
SeanCassiere merged 6 commits intoTanStack:mainfrom Apr 30, 2025
Merged
feat(router-devtools-core): add navigation link to route#4048SeanCassiere merged 6 commits intoTanStack:mainfrom
SeanCassiere merged 6 commits intoTanStack:mainfrom
Conversation
Contributor
|
View your CI Pipeline Execution ↗ for commit b84ad17.
☁️ Nx Cloud last updated this comment at |
scarf005
force-pushed
the
feat/devtool-link
branch
from
9e9fffd to
08443ae
Compare
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-config
@tanstack/react-start-plugin
@tanstack/react-start-router-manifest
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-config
@tanstack/solid-start-plugin
@tanstack/solid-start-router-manifest
@tanstack/solid-start-server
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-client-core
@tanstack/start-config
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
scarf005
force-pushed
the
feat/devtool-link
branch
4 times, most recently
from
826a26e to
33889cd
Compare
scarf005
force-pushed
the
feat/devtool-link
branch
3 times, most recently
from
88cfde9 to
517bd38
Compare
SeanCassiere
requested changes
Apr 28, 2025
Member
There was a problem hiding this comment.
I'd like to have some code comments added in for these functions/variables:
routeKind- Just comment in what each of the "kinds" mean.hasValidParamValueInMatch- Purpose of the function and comments at each exit statements and what that means.navigateToPath- Explain why there are different conditions for thestringbeing returned.
Overall, I like this PR and want to get this landed in.
Member
|
I'm trying to figure out why CI is failing, but I do not have a lot of time to look into it at the moment. @scarf005 please request a re-review from me once you've added in the changes I asked for. I'll run the tests locally and see if there's actually an "issue" with these changes that are somehow invisible at first-glance, or if its just the CI pipeline being difficult. |
scarf005
force-pushed
the
feat/devtool-link
branch
from
517bd38 to
5eb570d
Compare
Contributor
Author
|
@SeanCassiere hi, i refactored the code again and was able to simplify most of the logic. now |
…ilding logic reuse the `interpolatePath` function from router-core instead of manually trying to insert params into `route.fullPath`
SeanCassiere
approved these changes
Apr 30, 2025
scarf005
commented
Apr 30, 2025
Member
|
@scarf005 thank you for picking this up and contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2025-04-25_15-48-40.mp4