Skip to content

fix(directive-functions-plugin): do not outlaw generator functions#4080

Merged
SeanCassiere merged 5 commits intomainfrom
use-server-async-generator
May 4, 2025
Merged

fix(directive-functions-plugin): do not outlaw generator functions#4080
SeanCassiere merged 5 commits intomainfrom
use-server-async-generator

Conversation

@SeanCassiere
Copy link
Copy Markdown
Member

@SeanCassiere SeanCassiere commented May 3, 2025

Originating from downstream (SolidStart): solidjs/solid-start#1886

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 3, 2025

View your CI Pipeline Execution ↗ for commit 3b896c7.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 5m 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-04 00:08:54 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 3, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4080

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4080

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4080

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4080

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4080

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4080

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4080

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4080

@tanstack/react-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-config@4080

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4080

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4080

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-router-manifest@4080

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4080

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4080

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4080

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4080

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4080

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4080

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4080

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4080

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4080

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4080

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4080

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4080

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4080

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4080

@tanstack/solid-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-config@4080

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4080

@tanstack/solid-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-router-manifest@4080

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4080

@tanstack/start

npm i https://pkg.pr.new/TanStack/router/@tanstack/start@4080

@tanstack/start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-api-routes@4080

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4080

@tanstack/start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-config@4080

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4080

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4080

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4080

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-handler@4080

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4080

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-ssr@4080

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4080

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4080

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4080

commit: 3b896c7

@SeanCassiere SeanCassiere marked this pull request as ready for review May 4, 2025 00:11
@SeanCassiere SeanCassiere merged commit d2a1a04 into main May 4, 2025
11 of 17 checks passed
@SeanCassiere SeanCassiere deleted the use-server-async-generator branch May 4, 2025 01:45
Comment thread packages/directive-functions-plugin/tests/compiler.test.ts
@theturtle32
Copy link
Copy Markdown

@SeanCassiere Wow, thanks for hopping on this so quickly! I'm curious, do you know why generator functions were outlawed previously? Is there something else downstream that may not be expecting to have to handle generator functions?

@SeanCassiere
Copy link
Copy Markdown
Member Author

@SeanCassiere Wow, thanks for hopping on this so quickly! I'm curious, do you know why generator functions were outlawed previously? Is there something else downstream that may not be expecting to have to handle generator functions?

I'm not quite sure. TBF though, I still barely understand generators 😄

@theturtle32
Copy link
Copy Markdown

I'm not quite sure. TBF though, I still barely understand generators 😄

I feel you. Guess we'll find out together! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants