Skip to content

Conversation

@arackaf
Copy link
Contributor

@arackaf arackaf commented Sep 28, 2025

Summary by CodeRabbit

  • Documentation
    • Reworked React getting-started and quick-start content to prioritize a CLI-based project scaffolding flow.
    • Added npm/pnpm command examples and guidance on prompts for optional tools (Tailwind, ESLint, etc.).
    • Moved manual clone/setup instructions after the new CLI quick-start.
    • Minor wording and ordering improvements.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Reorders and rewrites React start docs to prioritize a CLI-based scaffold flow. Adds explicit npm create/pnpm create commands and prompt guidance, moves the manual clone setup later, and adjusts wording in both getting-started and quick-start pages. No code or API changes.

Changes

Cohort / File(s) Summary
Docs: React scaffold & quick-start
docs/start/framework/react/getting-started.md, docs/start/framework/react/quick-start.md
Replaced manual clone-first instructions with CLI-centered scaffolding (explicit npm create @tanstack/start@latest / pnpm create ...) and prompt guidance; reordered content so CLI flow appears before manual setup; minor heading and wording edits.

Sequence Diagram(s)

(omitted — changes are documentation-only and do not modify runtime/control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • docs: quickstart #5286 — Similar changes to React start docs replacing manual clone instructions with CLI-centered scaffold commands and prompting guidance.

Poem

I hopped through docs with nimble feet,
Swapped clone for create — a shortcut neat.
npm, pnpm, choose your art,
A scaffold fresh to jumpstart.
— Rabbit, nibbling markdown crumbs 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The provided title “Adam rackis/start docs tweak” is overly generic, includes the author’s name and branch context rather than summarizing the primary change, and fails to clearly convey that the pull request adds a quick-start scaffolding section to the React getting-started documentation. Please rename the title to a concise, descriptive phrase that reflects the main change, for example: “docs: add quick-start scaffolding section to React getting-started guide.”
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2018377 and 7938457.

📒 Files selected for processing (2)
  • docs/start/framework/react/getting-started.md (1 hunks)
  • docs/start/framework/react/quick-start.md (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the documentation Everything documentation related label Sep 28, 2025
@nx-cloud
Copy link

nx-cloud bot commented Sep 28, 2025

View your CI Pipeline Execution ↗ for commit 7938457

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-28 22:40:34 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 28, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5286

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5286

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5286

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5286

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5286

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5286

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5286

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5286

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5286

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5286

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5286

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5286

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5286

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5286

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5286

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5286

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5286

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5286

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5286

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5286

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5286

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5286

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5286

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5286

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5286

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5286

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5286

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5286

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5286

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5286

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5286

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5286

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5286

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5286

commit: 2018377

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docs/start/framework/react/getting-started.md (1)

8-8: Fix the self-link anchor.

The list still links to #start-a-new-project-from-scratch, but the heading now renders as #quickly-scaffolding-a-new-project, so the jump link is broken in the published docs. Please update the link target to match the new heading. (tanstack.com)

🧹 Nitpick comments (1)
docs/start/framework/react/getting-started.md (1)

18-26: Add shell language hints to the fenced blocks.

markdownlint flagged these code blocks; please tag them as shell (e.g. ```bash) so tooling and syntax highlighting work correctly.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2817a0c and 2018377.

📒 Files selected for processing (1)
  • docs/start/framework/react/getting-started.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
docs/**/*.{md,mdx}

📄 CodeRabbit inference engine (AGENTS.md)

Use internal docs links relative to the docs/ folder (e.g., ./guide/data-loading)

Files:

  • docs/start/framework/react/getting-started.md
docs/{router,start}/**

📄 CodeRabbit inference engine (AGENTS.md)

Place router docs under docs/router/ and start framework docs under docs/start/

Files:

  • docs/start/framework/react/getting-started.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: TanStack/router#0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.598Z
Learning: Applies to docs/{router,start}/** : Place router docs under docs/router/ and start framework docs under docs/start/
🪛 markdownlint-cli2 (0.18.1)
docs/start/framework/react/getting-started.md

18-18: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


24-24: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

@schiller-manuel schiller-manuel changed the title Adam rackis/start docs tweak docs: quickstart Sep 28, 2025
@schiller-manuel schiller-manuel merged commit 7a129f7 into TanStack:main Sep 28, 2025
4 of 5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Everything documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants