examples: fix paraglide start link example #5487
Conversation
WalkthroughThe README at Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)examples/{react,solid}/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
🪛 LanguageToolexamples/react/i18n-paraglide/README.md[grammar] ~141-~141: Use a hyphen to join words. (QB_NEW_EN_HYPHEN) [grammar] ~141-~141: There might be a mistake here. (QB_NEW_EN) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 521bda8
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
examples/react/i18n-paraglide/README.md (3)
57-71: Missing import for getLocale in example
getLocale()is used but not imported. Add it alongsideshouldRedirect(and ensure consistent import path/extension).-import { shouldRedirect } from "../paraglide/runtime"; +import { shouldRedirect, getLocale } from "../paraglide/runtime";
137-137: Typo: “plguin” → “plugin”-And import into the Paraglide Vite plguin. +And import into the Paraglide Vite plugin.
41-53: Remove unsupportedrewriteoption oncreateRouter
TanStack Router doesn’t support arewrite: { input, output }API. Instead, use route masks (createRouteMask/routeMasks) or preprocess URLs before initializing the router.
🧹 Nitpick comments (1)
examples/react/i18n-paraglide/README.md (1)
44-45: Inconsistent import paths/extensions for runtimeYou import from
./paraglide/runtime.jsin one snippet and../paraglide/runtimein another. Align paths and file extensions (TS vs JS ESM) to avoid confusion.Also applies to: 58-58
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/react/i18n-paraglide/README.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
examples/{react,solid}/**
📄 CodeRabbit inference engine (AGENTS.md)
Keep example applications under examples/react/ and examples/solid/
Files:
examples/react/i18n-paraglide/README.md
🪛 LanguageTool
examples/react/i18n-paraglide/README.md
[grammar] ~141-~141: Use a hyphen to join words.
Context: ...n. ## Server side rendering For server side rerdering, check out the [TanStack ...
(QB_NEW_EN_HYPHEN)
[grammar] ~141-~141: Ensure spelling is correct
Context: ... Server side rendering For server side rerdering, check out the [TanStack Start guide](h...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~141-~141: There might be a mistake here.
Context: ...in/examples/react/start-i18n-paraglide).
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (1)
examples/react/i18n-paraglide/README.md (1)
15-31: Confirm Vite plugin import path and options ImportingparaglideVitePluginfrom@inlang/paraglide-jswithprojectandoutdiroptions is correct per the official docs.
| ## Server side rendering | ||
|
|
||
| For server side rerdering, check out the [TanStack Start guide](https://inlang.com/m/gerre34r/library-inlang-paraglideJs/tanstack-start). | ||
| For server side rerdering, check out the [TanStack Start guide](https://github.com/TanStack/router/tree/main/examples/react/start-i18n-paraglide). |
There was a problem hiding this comment.
Fix spelling and hyphenation (“Server-side rendering”)
Two typos: “Server side” should be “Server-side”; “rerdering” → “rendering”.
-For server side rerdering, check out the [TanStack Start guide](https://github.com/TanStack/router/tree/main/examples/react/start-i18n-paraglide).
+For server-side rendering, check out the [TanStack Start guide](https://github.com/TanStack/router/tree/main/examples/react/start-i18n-paraglide).📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| For server side rerdering, check out the [TanStack Start guide](https://github.com/TanStack/router/tree/main/examples/react/start-i18n-paraglide). | |
| For server-side rendering, check out the [TanStack Start guide](https://github.com/TanStack/router/tree/main/examples/react/start-i18n-paraglide). |
🧰 Tools
🪛 LanguageTool
[grammar] ~141-~141: Use a hyphen to join words.
Context: ...n. ## Server side rendering For server side rerdering, check out the [TanStack ...
(QB_NEW_EN_HYPHEN)
[grammar] ~141-~141: Ensure spelling is correct
Context: ... Server side rendering For server side rerdering, check out the [TanStack Start guide](h...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~141-~141: There might be a mistake here.
Context: ...in/examples/react/start-i18n-paraglide).
(QB_NEW_EN)
🤖 Prompt for AI Agents
In examples/react/i18n-paraglide/README.md around line 141, fix the typos and
hyphenation in the sentence: change "For server side rerdering, check out the
[TanStack Start
guide](https://github.com/TanStack/router/tree/main/examples/react/start-i18n-paraglide)."
to read "For server-side rendering, check out the [TanStack Start
guide](https://github.com/TanStack/router/tree/main/examples/react/start-i18n-paraglide)."
ensuring "Server-side" is hyphenated and "rerdering" is corrected to
"rendering".
2 participants
Summary by CodeRabbit