-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add essential jsdoc to public api #5553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add essential jsdoc to public api #5553
Conversation
Co-authored-by: tannerlinsley <tannerlinsley@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
Caution Review failedThe pull request is closed. WalkthroughThe PR extends React Router's public API by adding two new lazy route factory functions ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The changes consist of straightforward API additions with comprehensive documentation. No complex logic modifications or structural refactors are involved. Review focuses on JSDoc accuracy, type constraint correctness, and API design consistency. Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Comment |
|
View your CI Pipeline Execution ↗ for commit 2ac788d
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Add JSDoc annotations to
getRouteApi,createLazyRoute, andcreateLazyFileRouteto improve IDE intellisense and in-editor documentation.Summary by CodeRabbit
Release Notes