Skip to content

test(solid-router): un-skip link tests #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkskyum merged 1 commit into from
Oct 25, 2025
Merged

test(solid-router): un-skip link tests #5621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/solid-router/src/link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ export function useLinkProps<
propsSafeToSpread,
{
ref,
href: externalLink,
href: externalLink(),
},
Solid.splitProps(local, [
'target',
Expand Down
17 changes: 8 additions & 9 deletions packages/solid-router/tests/link.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,8 +675,7 @@ describe('Link', () => {
expect(pageZero).toBeInTheDocument()
})

// TODO - THIS WORKS IN REACT
test.skip('when navigation to . from /posts while updating search from /', async () => {
test('when navigation to . from /posts while updating search from /', async () => {
const RootComponent = () => {
return (
<>
Expand Down Expand Up @@ -774,12 +773,13 @@ describe('Link', () => {

fireEvent.click(updateSearchLink)

const updatedPage = await screen.findByTestId('current-page')
const updatedFilter = await screen.findByTestId('current-filter')

// Verify search was updated
expect(window.location.pathname).toBe('/posts')
expect(window.location.search).toBe('?page=2&filter=inactive')

const updatedPage = await screen.findByTestId('current-page')
const updatedFilter = await screen.findByTestId('current-filter')
expect(updatedPage).toHaveTextContent('Page: 2')
expect(updatedFilter).toHaveTextContent('Filter: inactive')
})
Expand Down Expand Up @@ -1627,8 +1627,7 @@ describe('Link', () => {
expect(window.location.pathname).toBe('/posts/id1')
})

// TODO - THIS WORKS IN REACT
test.skip('when navigating from /posts/$postId to "/"', async () => {
test('when navigating from /posts/$postId to "/"', async () => {
const rootRoute = createRootRoute({
component: () => {
return (
Expand Down Expand Up @@ -1745,8 +1744,9 @@ describe('Link', () => {

fireEvent.click(homeLink)

expect(window.location.pathname).toBe('/')
const homeHeading = await screen.findByTestId('home-heading')

expect(window.location.pathname).toBe('/')
expect(homeHeading).toBeInTheDocument()

expect(consoleWarnSpy).not.toHaveBeenCalled()
Expand Down Expand Up @@ -6346,8 +6346,7 @@ describe('when on /posts/$postId and navigating to ../ with default `from` /post
})

describe('rewrite', () => {
// TODO - THIS WORKS IN REACT
test.skip('renders hard link when rewrite points to different origin', async () => {
test('renders hard link when rewrite points to different origin', async () => {
const rootRoute = createRootRoute()
const indexRoute = createRoute({
getParentRoute: () => rootRoute,
Expand Down
Loading