test(solid-start): add missing custom-basepath tests #5641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe PR adds three new routes to a SolidStart e2e test application with custom basepath configuration: a logout route demonstrating server function URL handling, and two redirect routes showcasing client-side and server-side redirect patterns. The generated route tree and integration tests are updated accordingly. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Browser
participant App
participant Server
rect rgb(200, 220, 240)
note over User,Server: Logout - Server Function Flow
User->>Browser: Navigate to /logout
Browser->>App: Load logout page
App->>User: Render form with server action
User->>Browser: Submit form
Browser->>Server: POST to /custom/basepath/_serverFn/...
Server->>Server: Execute logoutFn
Server->>Browser: Redirect to /
Browser->>App: Navigate to /
end
rect rgb(220, 240, 200)
note over User,Browser: Client-Side Redirect
User->>Browser: Navigate to /redirect
Browser->>App: Load redirect index
App->>User: Render link to /redirect/throw-it
User->>Browser: Click link
Browser->>App: Navigate to /redirect/throw-it
end
rect rgb(240, 220, 200)
note over Browser,App: Server-Side Redirect (beforeLoad)
Browser->>App: Load /redirect/throw-it
App->>App: Execute beforeLoad hook
App->>App: Throw redirect({ to: '/posts/1' })
App->>Browser: Redirect to /posts/1
Browser->>App: Navigate to /posts/1
App->>User: Render post view
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
🧰 Additional context used📓 Path-based instructions (3)**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/src/routes/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧬 Code graph analysis (4)e2e/solid-start/custom-basepath/src/routes/redirect.throw-it.tsx (1)
e2e/solid-start/custom-basepath/src/routes/logout.tsx (3)
e2e/solid-start/custom-basepath/src/routes/redirect.index.tsx (2)
e2e/solid-start/custom-basepath/src/routeTree.gen.ts (1)
🔇 Additional comments (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 4fc0f84
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-router-ssr-query
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
birkskyum
deleted the
test(solid-start)--add-missing-custom-basepath-tests
branch
This was referenced Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Tests
Chores