Skip to content

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Oct 27, 2025

Summary by CodeRabbit

  • Chores
    • Updated core dependency to the latest patch version across all example projects, test suites, and packages to maintain consistency and access incremental improvements.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 27, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updated solid-js dependency version from ^1.9.9 to ^1.9.10 across 50+ package.json files in the monorepo, including e2e tests, examples, and core packages.

Changes

Cohort / File(s) Summary
E2E Solid Router packages
e2e/solid-router/basepath-file-based/package.json, e2e/solid-router/basic-esbuild-file-based/package.json, e2e/solid-router/basic-file-based-code-splitting/package.json, e2e/solid-router/basic-file-based/package.json, e2e/solid-router/basic-scroll-restoration/package.json, e2e/solid-router/basic-solid-query-file-based/package.json, e2e/solid-router/basic-solid-query/package.json, e2e/solid-router/basic-virtual-file-based/package.json, e2e/solid-router/basic-virtual-named-export-config-file-based/package.json, e2e/solid-router/basic/package.json, e2e/solid-router/generator-cli-only/package.json, e2e/solid-router/js-only-file-based/package.json, e2e/solid-router/rspack-basic-file-based/package.json, e2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.json, e2e/solid-router/scroll-restoration-sandbox-vite/package.json, e2e/solid-router/sentry-integration/package.json
Bump solid-js from ^1.9.9 to ^1.9.10
E2E Solid Start packages
e2e/solid-start/basic-auth/package.json, e2e/solid-start/basic-solid-query/package.json, e2e/solid-start/basic-tsr-config/package.json, e2e/solid-start/basic/package.json, e2e/solid-start/custom-basepath/package.json, e2e/solid-start/query-integration/package.json, e2e/solid-start/scroll-restoration/package.json, e2e/solid-start/selective-ssr/package.json, e2e/solid-start/server-functions/package.json, e2e/solid-start/server-routes/package.json, e2e/solid-start/spa-mode/package.json, e2e/solid-start/virtual-routes/package.json, e2e/solid-start/website/package.json
Bump solid-js from ^1.9.9 to ^1.9.10
Example Solid packages
examples/solid/basic-devtools-panel/package.json, examples/solid/basic-file-based/package.json, examples/solid/basic-non-nested-devtools/package.json, examples/solid/basic-solid-query-file-based/package.json, examples/solid/basic-solid-query/package.json, examples/solid/basic-ssr-streaming-file-based/package.json, examples/solid/basic/package.json, examples/solid/kitchen-sink-file-based/package.json, examples/solid/kitchen-sink-solid-query-file-based/package.json, examples/solid/kitchen-sink-solid-query/package.json, examples/solid/quickstart-file-based/package.json, examples/solid/start-bare/package.json, examples/solid/start-basic-auth/package.json, examples/solid/start-basic-cloudflare/package.json, examples/solid/start-basic-netlify/package.json, examples/solid/start-basic-nitro/package.json, examples/solid/start-basic-solid-query/package.json, examples/solid/start-basic-static/package.json, examples/solid/start-basic/package.json
Bump solid-js from ^1.9.9 to ^1.9.10
Core packages
package.json (root pnpm overrides), packages/router-devtools-core/package.json (devDependencies), packages/solid-router-devtools/package.json (devDependencies and peerDependencies), packages/solid-router-ssr-query/package.json (devDependencies and peerDependencies), packages/solid-router/package.json (devDependencies and peerDependencies), packages/solid-start-server/package.json (devDependencies)
Bump solid-js from ^1.9.9 to ^1.9.10

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Highly homogeneous changes: identical version bump applied uniformly across 50+ files
  • No logic, control flow, or behavioral modifications
  • Simple, mechanical, and repetitive pattern requiring minimal differentiated analysis per file

Possibly related PRs

Suggested reviewers

  • schiller-manuel
  • lachlancollins

Poem

🐰 A hop, skip, and version jump!
From 1.9.9 to 1.9.10 we leap,
Fifty packages bundled up tight,
Solid goes down smooth as the night—
Our router runs brighter and keen! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "chore(solid): bump solid to 1.9.10" directly and accurately describes the changeset. The entire PR consists of updating the solid-js dependency from ^1.9.9 to ^1.9.10 across approximately 47 package.json files spanning e2e tests, examples, and core packages. The title is concise, clear, and uses conventional commit format (chore type), making it immediately understandable to anyone reviewing the repository history. The title fully captures the primary change without unnecessary noise or vagueness.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Oct 27, 2025

View your CI Pipeline Execution ↗ for commit d95339a

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 7m 41s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 39s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-27 21:46:08 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 27, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5661

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5661

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5661

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5661

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5661

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5661

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5661

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5661

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5661

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5661

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5661

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5661

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5661

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5661

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5661

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5661

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5661

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5661

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5661

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5661

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5661

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5661

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5661

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5661

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5661

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5661

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5661

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5661

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5661

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5661

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5661

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5661

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5661

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5661

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5661

commit: d95339a

@birkskyum birkskyum merged commit 818a4ee into main Oct 27, 2025
6 checks passed
@birkskyum birkskyum deleted the chore(solid)--bump-solid-to-1.9.10 branch October 27, 2025 22:02
@birkskyum birkskyum added this to the catch up solid to react milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants