Skip to content

test(solid-router): enhance transition test suite #5753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkskyum merged 4 commits into from
Nov 4, 2025
Merged

test(solid-router): enhance transition test suite #5753

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbdb617
test(solid-router): enhance transition test suite
birkskyum Nov 4, 2025
f6da91d
ci: apply automated fixes
autofix-ci[bot] Nov 4, 2025
3461780
don't clear interval repeatedly
birkskyum Nov 4, 2025
ae98ade
ci: apply automated fixes
autofix-ci[bot] Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 53 additions & 1 deletion e2e/solid-router/basic-file-based/tests/transition.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,30 @@ test('transitions should keep old values visible during navigation', async ({
if (text) bodyTexts.push(text)
}, 50)

// 1 click

await page.getByTestId('increase-button').click()

await expect(page.getByTestId('n-value')).toContainText('n: 1', {
timeout: 2_000,
})
await expect(page.getByTestId('double-value')).toContainText('double: 2', {
timeout: 2_000,
})

await page.waitForTimeout(200)

clearInterval(pollInterval)
await expect(page.getByTestId('n-value')).toContainText('n: 2', {
timeout: 2000,
})
await expect(page.getByTestId('double-value')).toContainText('double: 4', {
timeout: 2000,
})

// 2 clicks

await page.getByTestId('increase-button').click()
await page.getByTestId('increase-button').click()

await expect(page.getByTestId('n-value')).toContainText('n: 2', {
timeout: 2000,
Expand All @@ -31,6 +50,39 @@ test('transitions should keep old values visible during navigation', async ({
timeout: 2000,
})

await page.waitForTimeout(200)

await expect(page.getByTestId('n-value')).toContainText('n: 4', {
timeout: 2000,
})
await expect(page.getByTestId('double-value')).toContainText('double: 8', {
timeout: 2000,
})

// 3 clicks

await page.getByTestId('increase-button').click()
await page.getByTestId('increase-button').click()
await page.getByTestId('increase-button').click()

await expect(page.getByTestId('n-value')).toContainText('n: 4', {
timeout: 2000,
})
await expect(page.getByTestId('double-value')).toContainText('double: 8', {
timeout: 2000,
})

await page.waitForTimeout(200)

await expect(page.getByTestId('n-value')).toContainText('n: 7', {
timeout: 2000,
})
await expect(page.getByTestId('double-value')).toContainText('double: 14', {
timeout: 2000,
})

clearInterval(pollInterval)

// With proper transitions, old values should remain visible until new ones arrive
const hasLoadingText = bodyTexts.some((text) => text.includes('Loading...'))

Expand Down
Loading