Skip to content

example: add srvx start command for launching prod build #5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkskyum merged 2 commits into from
Nov 19, 2025
Merged

example: add srvx start command for launching prod build #5915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59d6dc8
example: add prod start command
birkskyum Nov 19, 2025
3f5cd8b
remove extra space
birkskyum Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/react-start/basic-react-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/basic-tsr-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "rimraf ./count.txt && vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"build": "vite build && tsc --noEmit",
"build:spa": "MODE=spa vite build && tsc --noEmit",
"build:prerender": "MODE=prerender vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start:spa": "node server.js",
"test:e2e:startDummyServer": "node -e 'import(\"./tests/setup/global.setup.ts\").then(m => m.default())' &",
"test:e2e:stopDummyServer": "node -e 'import(\"./tests/setup/global.teardown.ts\").then(m => m.default())'",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/query-integration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/scroll-restoration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/selective-ssr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/server-functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/server-routes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/virtual-routes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/basic-tsr-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "rimraf ./count.txt && vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"build": "vite build && tsc --noEmit",
"build:spa": "MODE=spa vite build && tsc --noEmit",
"build:prerender": "MODE=prerender vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start:spa": "node server.js",
"test:e2e:startDummyServer": "node -e 'import(\"./tests/setup/global.setup.ts\").then(m => m.default())' &",
"test:e2e:stopDummyServer": "node -e 'import(\"./tests/setup/global.teardown.ts\").then(m => m.default())'",
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/scroll-restoration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

✓ Script addition aligns with PR objectives.

The new start script correctly uses pnpx srvx --prod with proper client and server paths, matching the normalization pattern across other e2e packages in this PR. The srvx dependency (v^0.8.6) is already available in devDependencies.

Verify that the relative paths (../client and dist/server/server.js) are correct for the actual directory structure of this e2e project. Run this check to confirm:

🏁 Script executed:

#!/bin/bash
# Verify the start script paths exist relative to the e2e/solid-start/scroll-restoration directory

PROJECT_ROOT="e2e/solid-start/scroll-restoration"
CLIENT_PATH="e2e/solid-start/client"
SERVER_BUNDLE="$PROJECT_ROOT/dist/server/server.js"

# Check if ../client resolves correctly
if [ -d "$CLIENT_PATH" ]; then
  echo "✓ Client path (../client) resolves to: $CLIENT_PATH"
else
  echo "✗ Client path (../client) does not exist"
  # Find what's actually at ../client from the project
  ls -la "e2e/solid-start/" 2>/dev/null | grep -E '^d' || echo "  Directory listing failed"
fi

# Note: dist/server/server.js only exists after build, so we just verify the build target
echo "ℹ Server bundle path will be created at build time: $SERVER_BUNDLE"

Length of output: 1143

I've found a critical issue with the script paths. The verification shows that the ../client path does not exist. Let me investigate the actual directory structure to determine what the correct path should be.

I need to investigate the actual repository structure to determine what the correct client path should be. Let me search for other start scripts in the e2e directory and look for any client references.

The web search didn't provide the specific CLI documentation for srvx's -s flag. Let me search the repository directly to find how other e2e projects use srvx and what the correct path structure should be.


---

🏁 Script executed:

```shell
#!/bin/bash
# Search for other start scripts in the e2e/solid-start directory to find the pattern

echo "=== Finding all package.json files in e2e/solid-start ==="
find e2e/solid-start -name "package.json" -type f

echo ""
echo "=== Checking start scripts in e2e/solid-start package.json files ==="
for pkg in $(find e2e/solid-start -name "package.json" -type f); do
  echo "File: $pkg"
  cat "$pkg" | grep -A 2 '"start"' || echo "  No start script found"
  echo ""
done

echo "=== Checking for 'client' directory references in the repository ==="
rg -n "client" e2e/solid-start --type json -C 2 | head -50

Length of output: 6995

The search reveals a critical pattern: 11 packages use the identical broken path ../client, but there is NO client directory in e2e/solid-start/. However, spa-mode uses dist/client, suggesting the static files are built to dist/client. Let me verify the build configuration to understand the correct path.

🏁 Script executed:

#!/bin/bash
# Check vite configuration and build output structure

echo "=== Looking for vite config in scroll-restoration ==="
find e2e/solid-start/scroll-restoration -name "vite.config.*" -o -name "solid.config.*" | head -5

echo ""
echo "=== Checking if dist/client directory exists (after build would be created) ==="
ls -la e2e/solid-start/scroll-restoration/dist 2>/dev/null || echo "dist directory does not exist (expected - not built yet)"

echo ""
echo "=== Searching for vite config in the entire e2e/solid-start directory ==="
find e2e/solid-start -name "vite.config.*" -type f

echo ""
echo "=== Checking one vite.config to understand build output ==="
if [ -f "e2e/solid-start/basic/vite.config.ts" ]; then
  echo "=== Contents of e2e/solid-start/basic/vite.config.ts ==="
  cat "e2e/solid-start/basic/vite.config.ts"
fi

Length of output: 2211

Now let me check the scroll-restoration vite config specifically and verify whether the ../client path was introduced in this PR:

🏁 Script executed:

#!/bin/bash
# Check scroll-restoration's vite config and verify the issue

echo "=== Contents of scroll-restoration vite.config.ts ==="
cat e2e/solid-start/scroll-restoration/vite.config.ts

echo ""
echo "=== Checking git history to see if ../client was recently added ==="
cd e2e/solid-start/scroll-restoration 2>/dev/null || cd . 
git log -p --follow -S '../client' -- 'package.json' 2>/dev/null | head -100 || echo "Git history not available or no matches found"

echo ""
echo "=== Checking if there's any reference to a shared client directory ==="
find e2e/solid-start -maxdepth 1 -type d -name "*client*" 2>/dev/null || echo "No client directories found at e2e/solid-start/ level"

Length of output: 641

Critical: The relative path ../client is broken and will cause runtime failures.

The start script references a non-existent ../client directory. Relative to e2e/solid-start/scroll-restoration/, the path ../client resolves to e2e/solid-start/client/, which does not exist. Based on TanStack Start's default build output structure and the spa-mode package's use of dist/client, the correct path should be dist/client:

- "start": "pnpx srvx --prod -s ../client dist/server/server.js",
+ "start": "pnpx srvx --prod -s dist/client dist/server/server.js",

Note: This same broken path appears in 10 other packages in this PR (basic-solid-query, basic-tsr-config, basic, query-integration, selective-ssr, serialization-adapters, server-functions, server-routes, virtual-routes, website). All 11 packages need this fix.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s dist/client dist/server/server.js",
🤖 Prompt for AI Agents 
e2e/solid-start/scroll-restoration/package.json lines 10-10: the "start" script
uses a broken relative path "../client" that resolves to a non-existent
directory; update the script to reference the built client output "dist/client"
(so the start command points to dist/client instead of ../client); apply the
same change to the start scripts in the other affected packages:
basic-solid-query, basic-tsr-config, basic, query-integration, selective-ssr,
serialization-adapters, server-functions, server-routes, virtual-routes, and
website.

"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/selective-ssr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/server-functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/server-routes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/virtual-routes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-start/website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"test:e2e": "rm -rf port*.txt; playwright test --project=chromium"
},
"dependencies": {
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-bare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/react-router": "^1.136.18",
Expand Down
1 change: 1 addition & 0 deletions examples/react/start-basic-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"scripts": {
"dev": "vite dev",
"build": "vite build",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"prisma-generate": "prisma generate"
},
"dependencies": {
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-basic-react-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/react-query": "^5.90.0",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-basic-rsc/package.disabled.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build"
"build": "vite build",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@babel/plugin-syntax-typescript": "^7.25.9",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-basic-static/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/react-router": "^1.136.18",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-clerk-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@clerk/tanstack-react-start": "^0.26.3",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-convex-trellaux/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"dev": "npx convex dev --once && concurrently -r npm:dev:web npm:dev:db",
"dev:web": "vite dev",
"dev:db": "convex dev --run board:seed",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@convex-dev/react-query": "0.0.0-alpha.8",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-counter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/react-router": "^1.136.18",
Expand Down
1 change: 1 addition & 0 deletions examples/react/start-large/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"gen": "node ./src/createRoutes.mjs",
"test:types": "tsc --extendedDiagnostics"
},
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-material-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@emotion/cache": "11.14.0",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-streaming-data-from-server-functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/react-router": "^1.136.18",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-supabase-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"keywords": [],
"author": "",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-trellaux/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/react-query": "^5.90.0",
Expand Down
3 changes: 2 additions & 1 deletion examples/react/start-workos/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"keywords": [],
"author": "",
Expand Down
1 change: 1 addition & 0 deletions examples/solid/start-basic-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"scripts": {
"dev": "vite dev",
"build": "vite build",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"prisma-generate": "prisma generate"
},
"dependencies": {
Expand Down
3 changes: 2 additions & 1 deletion examples/solid/start-basic-solid-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/solid-query": "^5.90.9",
Expand Down
3 changes: 2 additions & 1 deletion examples/solid/start-basic-static/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build"
"build": "vite build",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/solid-router": "^1.136.17",
Expand Down
3 changes: 2 additions & 1 deletion examples/solid/start-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
Comment on lines +8 to +9
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Fix missing srvx dependency and invalid static directory path.

The start script references srvx without declaring it as a dependency, and points to a non-existent directory. The script will fail when executed.

Add srvx to devDependencies (as in examples/react/start-clerk-basic/package.json), and correct the static path from ../client to the actual build output location of client assets for this project.

I'll verify the review comment by checking the codebase and package information.


---

🏁 Script executed:

```shell
#!/bin/bash
# Verify srvx dependency in start-basic package.json
echo "=== examples/solid/start-basic/package.json ===" 
cat examples/solid/start-basic/package.json | jq '.devDependencies, .dependencies' 2>/dev/null || cat examples/solid/start-basic/package.json

# Check if ../client directory exists
echo -e "\n=== Checking examples/solid/client directory ==="
ls -la examples/solid/client 2>&1 || echo "Directory does not exist"

# Check directory structure
echo -e "\n=== examples/solid directory structure ==="
ls -la examples/solid/

# Compare with react example
echo -e "\n=== examples/react/start-clerk-basic/package.json dependencies ==="
cat examples/react/start-clerk-basic/package.json 2>/dev/null | jq '.devDependencies, .dependencies' || echo "File not found"

Length of output: 5037

🌐 Web query:

srvx npm package documentation dependencies

💡 Result:

Summary — srvx (npm)

  • Documentation / homepage: srvx.h3.dev. [1]
  • npm package page (install: npm i srvx): shows package info and README. [2]
  • Dependencies: srvx is advertised as having zero runtime dependencies (no entries in package.json dependencies). Dev/build tooling uses pnpm/Corepack in the repo. [2][3]

If you want I can fetch the package.json from the srvx GitHub repo and list the exact dependencies/devDependencies with versions.

Fix missing srvx dependency and invalid static directory path in examples/solid/start-basic/package.json.

The start script references srvx without declaring it as a dependency, and points to a non-existent ../client directory. The script will fail when executed.

Add srvx to dependencies (matching examples/react/start-clerk-basic/package.json which declares "srvx": "0.8.15"), and correct the static path to the actual location of client build outputs for this project.

🤖 Prompt for AI Agents 
In examples/solid/start-basic/package.json around lines 8 to 9, the start script
references an undeclared `srvx` dependency and an incorrect static path; add
`"srvx": "0.8.15"` to the package.json dependencies (not devDependencies) to
match examples/react/start-clerk-basic, and update the start script static path
from `../client` to the actual client build output directory (e.g.,
`dist/client` or whichever folder your Vite build emits) so the command becomes
`pnpx srvx --prod -s <correct-client-path> dist/server/server.js`.

},
"dependencies": {
"@tanstack/solid-router": "^1.136.17",
Expand Down
3 changes: 2 additions & 1 deletion examples/solid/start-convex-better-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"scripts": {
"dev": "vite dev",
"convex:dev": "convex dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@convex-dev/better-auth": "^0.9.7",
Expand Down
3 changes: 2 additions & 1 deletion examples/solid/start-counter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/solid-router": "^1.136.17",
Expand Down
1 change: 1 addition & 0 deletions examples/solid/start-large/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js",
"gen": "node ./src/createRoutes.mjs",
"test:types": "tsc --extendedDiagnostics"
},
Expand Down
3 changes: 2 additions & 1 deletion examples/solid/start-streaming-data-from-server-functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"dependencies": {
"@tanstack/solid-router": "^1.136.17",
Expand Down
3 changes: 2 additions & 1 deletion examples/solid/start-supabase-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "vite build && tsc --noEmit"
"build": "vite build && tsc --noEmit",
"start": "pnpx srvx --prod -s ../client dist/server/server.js"
},
"keywords": [],
"author": "",
Expand Down
Loading