chore: remove extra comments #5946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThis PR removes numerous JSDoc/comment blocks and deletes several exported types, interfaces, functions, and a class across react-router, router-core, solid-router, and start-server-core. No runtime logic changes were made; changes primarily reduce public API surface and clean up documentation. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit fdb8252
☁️ Nx Cloud last updated this comment at |
| * @returns A function that accepts Route options and returns a Route instance. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createFileRouteFunction | ||
| */ | ||
| /** |
Contributor
There was a problem hiding this comment.
this still has duplicated jsdocs
| @@ -292,18 +276,6 @@ | |||
| } | |||
| @@ -1,4 +1,3 @@ | |||
| /* eslint-disable react-hooks/rules-of-hooks */ | |||
| @@ -247,4 +243,4 @@ | |||
| 5: number | ||
| } | ||
|
|
||
| /** |
| return output as ParsedSegment | ||
| } | ||
|
|
||
| /** |
| } | ||
| } | ||
|
|
||
| /** |
| >(1000) | ||
| } | ||
|
|
||
| /** |
| return result | ||
| } | ||
|
|
||
| /** |
| return path === '/' ? path : path.replace(/\/{1,}$/, '') | ||
| } | ||
|
|
||
| /** |
| cache?: LRUCache<string, string> | ||
| } | ||
|
|
||
| /** |
| export type TrailingSlashOption = | ||
| (typeof trailingSlashOptions)[keyof typeof trailingSlashOptions] | ||
|
|
||
| /** |
| TDehydrated | ||
| > | ||
|
|
||
| /** |
| return normalize(a) === normalize(b) | ||
| } | ||
|
|
||
| /** |
| return {} | ||
| } | ||
|
|
||
| /** |
| type IntegrityAlgorithm = 'sha256' | ||
| /** @internal */ | ||
| type _Algorithm = EncryptionAlgorithm | IntegrityAlgorithm | ||
| /** |
schiller-manuel
force-pushed
the
fix/remove-extra-comments
branch
from
acf36f0 to
0e2c2a1
Compare
schiller-manuel
force-pushed
the
fix/remove-extra-comments
branch
from
8aac007 to
fdb8252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Refactor
Breaking Changes
✏️ Tip: You can customize this high-level summary in your review settings.