-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: ignore route pieces in RoutePrefixMap #6186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughFixes a bug in the router-cli where lazy route variants were incorrectly prioritized over regular routes when resolving parent routes. Adds a guard in RoutePrefixMap constructor to exclude lazy, loader, and component-related route pieces from the prefix map, preventing them from being considered valid parent candidates. Includes test fixtures and snapshot demonstrating the corrected behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (7)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{js,ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (9)📓 Common learnings📚 Learning: 2025-12-17T02:17:55.086ZApplied to files:
📚 Learning: 2025-10-08T08:11:47.088ZApplied to files:
📚 Learning: 2025-12-06T15:03:07.223ZApplied to files:
📚 Learning: 2025-10-01T18:31:35.420ZApplied to files:
📚 Learning: 2025-12-21T12:52:35.231ZApplied to files:
📚 Learning: 2025-11-02T16:16:24.898ZApplied to files:
📚 Learning: 2025-12-06T15:03:07.223ZApplied to files:
📚 Learning: 2025-10-01T18:30:26.591ZApplied to files:
🧬 Code graph analysis (2)packages/router-generator/tests/generator/lazy/routes/__root.tsx (1)
packages/router-generator/tests/generator/lazy/routes/posts.$postId.tsx (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (7)
Comment |
|
View your CI Pipeline Execution ↗ for commit 47d2ac8
☁️ Nx Cloud last updated this comment at |
fixes #6142
Summary by CodeRabbit
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.