Conversation
…piling a single regex decoder
|
View your CI Pipeline Execution ↗ for commit d386732
☁️ Nx Cloud last updated this comment at |
📝 WalkthroughWalkthroughThis PR refactors path parameter decoding across router-core from a Map-based approach ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
interpolatePathis in the hot path for most things (Link, navigation, preload, ...)This PR adds a total of 8 lines of code (excluding comments) but significantly improves performance (by 0 to 70%) depending on the input string.
bench
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.