fix(virtual-core): Add option to disable element dimension rounding for improved scrolling precision#841
Closed
ms-austin-beaulieu wants to merge 1 commit intoTanStack:mainfrom
Closed
Conversation
Due to default element dimension rounding, programatic scrolling while at the bottom of very large lists can be unstable when element dimensions contain sub-pixel values. Adding an option to the virtualizer fixes this when this level of precision is needed
Collaborator
|
Thanks for the contribution! Since the change in #986 uses offsetWidth / offsetHeight which already return integer values as a fallback, that should effectively prevent rounding issues and improve scrolling precision. Closing this for now, as the underlying issue should be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
roundElementDimensionsprop to theVirtualizerOptions, allowing users to disable the default behavior of rounding element dimensions.Problem:
Programmatic scrolling at the bottom of very large lists can become unstable when elements contain sub-pixel dimensions due to the default rounding of
getBoundingClientRectvalues. This instability is particularly noticeable in lists with high precision layout requirements.Solution:
The newly added
roundElementDimensions?: booleanprop allows users to control whether element dimensions are rounded. By default, this prop is set totrue, maintaining the current behavior. When set tofalse, rounding is skipped, ensuring more precise scrolling behavior in scenarios where sub-pixel accuracy is needed.