Potential fix for code scanning alert no. 22: Incomplete URL substring sanitization#5
Draft
Potential fix for code scanning alert no. 22: Incomplete URL substring sanitization#5
Conversation
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Repository owner
locked and limited conversation to collaborators
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/stagehand/security/code-scanning/22
In general, to fix incomplete URL substring sanitization, you should parse the URL and compare its structured components (protocol, host, pathname) instead of using
String.includeson the whole URL. This avoids matches where the expected domain appears in query parameters, path segments, or as part of another domain.For this specific case, the intent is to confirm that the page is actually on Uber’s authentication domain when the evaluator says “YES”. The best fix is to replace
page.url().includes("https://auth.uber.com/")with a comparison based on the parsed URL’s origin or hostname. In Node/TypeScript we can safely use the built‑inURLclass (no new imports needed). We should also avoid changing other behavior, so we’ll keep theevaluation === "YES"logic and just tighten the URL check.Concretely, in
packages/evals/tasks/agent/ubereats.ts, around line 26–27, we will:currentUrl = page.url();.const parsedUrl = new URL(currentUrl);.const isAuthDomain = parsedUrl.origin === "https://auth.uber.com";(or equivalently, checkhostname === "auth.uber.com"andprotocol === "https:").page.url().includes("https://auth.uber.com/")condition withisAuthDomain.No new imports are needed, because
URLis globally available in recent Node.js and TypeScript targets.Suggested fixes powered by Copilot Autofix. Review carefully before merging.