Potential fix for code scanning alert no. 23: Incomplete URL substring sanitization#6
Draft
Potential fix for code scanning alert no. 23: Incomplete URL substring sanitization#6
Conversation
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Repository owner
locked and limited conversation to collaborators
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/stagehand/security/code-scanning/23
In general, to fix incomplete URL substring sanitization, you should parse the URL and compare its
host(orhostname) against an expected value or whitelist, instead of checking substrings on the entire URL string. This prevents cases where the target domain appears in the path, query, or as part of another hostname.For this specific test, we want to assert that the loaded page is
https://example.com(or at least that its host is exactlyexample.com). The best minimal fix is to parsepageUrlusing the standardURLclass (available in Node and browsers) and assert onurl.hostname === "example.com". This avoids sloppy substring matching while preserving the semantics that the test expects.Concretely:
packages/server/test/integration/v3/navigate.test.ts, replace theassert.ok(pageUrl.includes("example.com"), ...)line with logic that:URLfrompageUrl.parsed.hostname === "example.com".try/catchor rely on the test failing naturally ifpageUrlis invalid; given this is a controlled test, the simple use ofnew URL(pageUrl)is sufficient.URLis a global in Node 18+ and modern environments.Suggested fixes powered by Copilot Autofix. Review carefully before merging.