Potential fix for code scanning alert no. 15: Shell command built from environment values#37
Open
Potential fix for code scanning alert no. 15: Shell command built from environment values#37
Conversation
…m environment values Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/vite/security/code-scanning/15
In general, this type of issue is fixed by avoiding shell interpretation of dynamically constructed commands: instead of building a single command string, call the executable directly and pass arguments as an array. For
execa/execaCommand, this means usingexecawithshell: false(the default) and giving the program and its arguments separately. This prevents spaces or metacharacters inviteBinPathor other arguments from altering the command structure.Concretely here, we should:
buildCommandandserverCommandwith argument arrays.execainstead ofexecaCommandso that the first parameter is the executable (hereviteBinPath) and the second is the array of CLI arguments.viteBinPathunchanged; only change how it is invoked."${buildCommand}"/"${serverCommand}"to use a safe, readable representation of the command (for example, by joining[viteBinPath, ...args]with spaces for logging only).These changes are all confined to
playground/cli-module/__tests__/serve.ts. We need to:execaimport without removingexecaCommandif it’s still referenced elsewhere in the file (outside the shown snippet we cannot touch).execa(viteBinPath, ['build'], ...).execa(viteBinPath, viteServerArgs, ...).catchblock and in theclosehelper to reflect the new representation.Suggested fixes powered by Copilot Autofix. Review carefully before merging.