Potential fix for code scanning alert no. 23: Exception text reinterpreted as HTML#44
Open
Potential fix for code scanning alert no. 23: Exception text reinterpreted as HTML#44
Conversation
…reted as HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/vite/security/code-scanning/23
In general, to fix this issue you should avoid sending raw exception messages or stack traces directly to an HTML response. Instead, either (1) send a generic, constant error message to the client and log detailed information on the server, or (2) if detailed information must be shown, ensure it is properly escaped and sent as text, not HTML.
The best fix here, without changing existing functionality too much, is to stop sending
e.stackback to the browser and instead send a generic error message (e.g. "Internal Server Error") while keeping the detailed error logged server-side. This preserves current logging behavior (console.log(e.stack)) and therefore debuggability, but removes the XSS vector. Concretely, inplayground/ssr-pug/server.js, in the catch block of theapp.use('*all', ...)handler, replaceres.status(500).end(e.stack)withres.status(500).end('Internal Server Error')(or similar static text). No extra imports or helpers are needed.Change details:
playground/ssr-pug/server.jscatch (e) { ... }block around lines 59–63.e.stackin the HTTP response and return a constant error message instead.Suggested fixes powered by Copilot Autofix. Review carefully before merging.