Potential fix for code scanning alert no. 37: Prototype-polluting function#46
Draft
Potential fix for code scanning alert no. 37: Prototype-polluting function#46
Conversation
…ction Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Repository owner
locked and limited conversation to collaborators
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/vite/security/code-scanning/37
In general, to prevent prototype pollution in deep merge/clone helpers, avoid writing or recursing into special keys that can change object prototypes (
__proto__,constructor, andprototype), or restrict recursive merging to existing own properties on the destination. This ensures that user-controlled data cannot modifyObject.prototypeor other prototypes via crafted keys.For this code, the least invasive and most compatible fix is to introduce a small helper that detects unsafe keys and then skip such keys in both
deepCloneandmergeWithDefaultsRecursively. Concretely:isUnsafeKey(key: string): boolean, that returns true for__proto__,constructor, andprototype.deepClone, before processing eachkeyfromvalue, checkif (isUnsafeKey(key)) continue;so these problematic properties are never cloned into new objects.mergeWithDefaultsRecursively, before readingvalues[key]or assigning tomerged[key], addif (isUnsafeKey(key)) continue;to completely ignore such keys during merging.packages/vite/src/node/utils.ts. No new imports are needed.This preserves existing functionality for all normal keys, while dropping only the dangerous ones from user-controlled input, which is standard practice for mitigating prototype pollution.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.