Potential fix for code scanning alert no. 25: Uncontrolled data used in path expression#56
Draft
Potential fix for code scanning alert no. 25: Uncontrolled data used in path expression#56
Conversation
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Repository owner
locked and limited conversation to collaborators
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/vite/security/code-scanning/25
General approach: Ensure any filesystem path derived from
req.urlis both normalized and validated to be within an allowed root before use. This matches the guidance: normalize (path.resolve/realpathSync) and then assert containment using a root directory (isParentDirectory).Best concrete fix here: the non-
FS_PREFIXbranch already follows this pattern. We should mirror that for theFS_PREFIXdev branch by:fs.realpathSync.nativeto collapse symlinks.isParentDirectory.next()if the check fails, before anyfs.existsSync/fsp.readFilecalls.We will only modify
packages/vite/src/node/server/middlewares/indexHtml.tsinside the snippet shown, specifically theif (isDev && url.startsWith(FS_PREFIX)) { ... }block around lines 498–516. We already importnormalizePath,isParentDirectory,fs, andpath, so no new imports or utilities are needed.Behavioral impact: For dev requests using
FS_PREFIX, any attempt to access files outsideroot(via traversal or craftedFS_PREFIXpaths) will now be rejected (falling through tonext()/ other middleware) instead of being served.Suggested fixes powered by Copilot Autofix. Review carefully before merging.