feat(streaming): add shared stream topic constants#24
Merged
Conversation
Merge dev into main
…-stream-topic-constants
Member
|
@BaoT1301 what's this for? |
Member
|
@BaoT1301 what’s this PR for? |
Member
Author
|
Hey @jrb00013 , this is the for Python-side shared constants, the stream names already exist in the plan and are currently used as local string literals in Cyrex/Helox. This PR puts those names into deepiri-modelkit so Python services can import the same contract instead of duplicating strings. It is not implementing routing, schemas or ingestion. It is just the shared Python topic registry, matching what shared-utils does for TypeScript. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT:
Description
Adds shared Python stream topic constants for the current Deepiri data-streaming contract so Python services can reference the same
document.*and Cyrex-to-Helox training stream names without duplicating string literals.Include:
deepiri-modelkitstreaming topic registryChanges
DOCUMENT_VECTORIZE = "document.vectorize"DOCUMENT_TRAINING = "document.training"DOCUMENT_STRUCTURED = "document.structured"DOCUMENT_ARTIFACTS = "document.artifacts"HELOX_TRAINING_RAW = "pipeline.helox-training.raw"HELOX_TRAINING_STRUCTURED = "pipeline.helox-training.structured"devso the PR includes the latest shared sidecar utility changes.Related
Testing
Verified locally:
python -m py_compile src/deepiri_modelkit/streaming/topics.pygit diff --checkAdditional testing details:
Important Notes (Optional)
TOPIC_EVENT_SCHEMAS.Workflow Checklist (Required)
Review Requests
@Team-Deepiri/support-team