fix: stablized env defaults, removed MongoDB wiring#196
Conversation
- added required env variables and defaults - fixed Docker build issues and missing contexts - implemented runtime fallbacks for process.env - resolved service networking (auth-service, external-bridge) - verified QA services build and run locally
|
@devcodesfr we need this code in production branch please bro |
|
@jrb00013 I proceeded with testing by rebuilding ( it seems that Docker is failing at pulling the base image from |
|
@devcodesfr how is this now? is this good sir? |
| npm install --legacy-peer-deps && \ | ||
| npm cache clean --force && \ | ||
| echo "@team-deepiri:registry=https://npm.pkg.github.com" > .npmrc | ||
| rm -f package-lock.json && npm install --legacy-peer-deps /shared-utils.tgz && \ |
There was a problem hiding this comment.
Why are we removing the package lock json here?
| && npm install --legacy-peer-deps \ | ||
| && npm cache clean --force \ | ||
| && echo "@team-deepiri:registry=https://npm.pkg.github.com" > .npmrc | ||
| && rm -f package-lock.json && npm install --legacy-peer-deps \ |
| GOOGLE_CLIENT_SECRET=your-google-client-secret | ||
| EXTERNAL_BRIDGE_BASE_URL=http://localhost:5006 | ||
| AUTH_SERVICE_URL=http://auth-service:5001 | ||
|
|
There was a problem hiding this comment.
This has just created them in env. example, we actually need default values in the os.env as needed.
…on lines to 'RUN npm ci'
|
@jrb00013 note: I switched Dockerfile installs from |
|
@runbinz please review this |
|
@runbinz @Team-Deepiri/support-team @austinm2h35-sketch @asheenhameeda8-cpu |
|
@devcodesfr there was maybe some leftover mongodb artifacts your AI read in the core-api which made it think mongodb was needed. Is this all good now? Whats the progress of this PR and #207 |
|
@jrb00013 |
|
@devcodesfr did you update to deepiri suite? |
|
Why are you using a token to access it? What token? We told you to setup ssh for git credentials |
|
@Team-Deepiri/support-team can someone test his code on here |
|
This needs to be assigned someone to test the build and services to make sure they're healthy @Team-Deepiri/support-team |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… through an exception' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… through an exception' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… through an exception' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
I've successfully confirmed that all services still build and start healthily with the removal of MongoDB. I also fixed some backend build errors and changed Dockerfiles to use let me know if there are any other issues. |
|
@runbinz This is assigned to you as well. Test/Review it ASAP!! |
devcodesfr
changed the title
Merge dev into main
Rename scripts/test_password_security.sh to scripts/testing/test_pass…
…arted-docs added in documentation
|
@devcodesfr bro which one do we close this one or 207 |
|
@austinm2h35-sketch keep track of his answer and close if needed |
|
@Team-Deepiri/support-team now someone test this PR please to make sure no services break |
sergiovargas111
requested review from
sergiovargas111
and removed request for
sergiovargas111
|
❌ QA Rejected Issue 1: MongoDB still present Reproduce: grep -r "mongoose|MONGODB_URI|MONGO_URI" ~/Deepiri/deepiri-platform/deepiri-core-api/src/ Expected: No MongoDB references found. Issue 2: Docker QA build fails When rebuilding, communications-hub fails with npm error Cannot read properties of undefined (reading 'extraneous') on the latest code. This occurs during Reproduce: team_dev_environments/qa-team/./build.sh Expected: All services build successfully with exit code 0. |
|
Core-API is an old archived repo, all other MongoDB stuff was already taken
out.
…On Fri, May 15, 2026 at 3:18 AM Sergio Vargas ***@***.***> wrote:
*sergiovargas111* left a comment (Team-Deepiri/deepiri-platform#196)
<#196 (comment)>
❌ QA Rejected
Issue 1: MongoDB still present
Mongoose is still actively used across source code, runtime, tests, and
dependencies on this branch. Confirmed by reviewing the codebase and
finding references including active database connection logic and model
definitions.
Reproduce: grep -r "mongoose|MONGODB_URI|MONGO_URI"
~/Deepiri/deepiri-platform/deepiri-core-api/src/
Expected: No MongoDB references found.
Issue 2: Docker QA build fails
When rebuilding, communications-hub fails with npm error Cannot read
properties of undefined (reading 'extraneous') on the latest code. This
occurs during npm ci --legacy-peer-deps in the shared-utils build step,
causing the QA environment to fail to start.
Reproduce: team_dev_environments/qa-team/./build.sh
Expected: All services build successfully with exit code 0.
—
Reply to this email directly, view it on GitHub
<#196 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFHDDTDED4B5FYFAJF7WXSD423ADHAVCNFSM6AAAAACYFZ45H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINJXHAYDENZUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
7 participants
Description
Adds runtime environment defaults for local QA/dev setup and removes unused MongoDB wiring from the platform.
This PR ensures required environment values have safe local fallbacks where they are accessed at runtime, while also removing MongoDB-related configuration, dependencies, scripts, and references now that MongoDB is no longer used.
Changes
GOOGLE_CLIENT_ID,GOOGLE_CLIENT_SECRET,EXTERNAL_BRIDGE_BASE_URL,AUTH_SERVICE_URLhttp://auth-service:5001http://external-bridge-service:5006Testing
Important Notes (Optional)
Workflow Checklist
Review Requests
@jrb00013