Network [#25] Login & Onboarding 네트워크 연결 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoe0929
approved these changes
May 21, 2024
Member
Zoe0929
left a comment
Zoe0929
left a comment
There was a problem hiding this comment.
👍 고생하셨습니다! 소셜 로그인이 두개라 구현 어려우셨을텐데 좋아요오
Comment on lines
+13
to
+14
| @StateObject var loginViewModel = LoginViewModel() | ||
| @StateObject var userManager = UserManager.shared |
| // | ||
|
|
||
| import Foundation | ||
| import SwiftUI |
Member
There was a problem hiding this comment.
❓ SwiftUI 사용한 부분이 크게 없어보여서 Foundation만 import 해도 좋을 것 같은데, SwiftUI를 import한 이유가 있을까요?
Comment on lines
+11
to
+13
| @AppStorage("accessToken") var accessToken = "" | ||
| @AppStorage("refreshToken") var refreshToken = "" | ||
| @AppStorage("socialToken") var socialToken = "" |
Member
Author
There was a problem hiding this comment.
토큰 키체인 도입 꼭 필요할 것 같아요! 알아 보겠습나다!!
Comment on lines
122
to
125
| // self.setRootViewController(SignInCompleteViewController()) | ||
| // guard let data = data.data else { return } | ||
| // UserManager.shared.updateToken(data.token.accessToken, data.token.refreshToken) | ||
| // UserManager.shared.updateUserId(data.userId) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
UserManager.shared.accessToken = data.token.accessToken(이어서 추가 작성 하겠음)
🚀 PR Point
✅ CheckList
🔗 Issue
Resolved #25