[Feat] #566 - 추천소 채팅 뷰에서 예시 질의 버튼 디자인 개선 #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
행간 설정(160%), 여러 단어에 볼드처리(다른 폰트 적용) 가능하도록 변경
2 tasks
Johyerin
approved these changes
Jun 20, 2025
Collaborator
Johyerin
left a comment
Johyerin
left a comment
There was a problem hiding this comment.
수정사항 잘 적용된 것 확인했습니다! 고생하셨씁니다~
Comment on lines
+61
to
+70
|
|
||
| for highlightedText in question.highlightedTexts { | ||
| let range = (question.title as NSString).range(of: highlightedText) | ||
| attributedString.addAttribute( | ||
| .foregroundColor, | ||
| value: UIColor.blackOpacity(.black55), | ||
| range: range | ||
| ) | ||
| } | ||
| titleLabel?.attributedText = attributedString |
Collaborator
There was a problem hiding this comment.
P5
UILabel extension에 빼둔 highlightText의 파라미터를 배열화하여 활용해도 좋을 것 같아서 해봤는데 잘 적용이 되지 않는 것 같네요... 흠 요 부분 고려해서 디벨롭해봐도 좋을 것 같은데 지금은 넘어가도 괜찮을 것 같습니다!
Contributor
Author
There was a problem hiding this comment.
저도 같은 생각입니다! 나중에 기회가 되면 이 기능 UILabel의 확장으로 빼면 좋을 것 같아요.
지금은 여러 글자에 동시에 적용하는 걸 임시로 구현해본 거라서 나중에 개선사항으로 남겨두면 좋을 것 같습니다.
(아니면 NSAttributedString, NSMutableAttributedString 의 확장으로 구현해서 활용하는 것도 좋을 것 같습니다!)
codeJiwon
approved these changes
Jun 21, 2025
Member
codeJiwon
left a comment
codeJiwon
left a comment
There was a problem hiding this comment.
추천소 채팅 뷰 개선사항 잘 적용된 것 확인했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 작업한 브랜치
✅ 작업한 내용
변경사항이 많지 않아, 위 변경사항들을 하나의 커밋으로 반영하였으니, 참고 바랍니다.
❗️PR Point
📸 스크린샷