feat: 피드 수정시 비공개 여부 반영 #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m6z1
requested changes
May 3, 2025
| override fun onResume() { | ||
| super.onResume() | ||
|
|
||
| myActivityViewModel.updateMyActivities() |
Member
There was a problem hiding this comment.
r: onResume 에서 활동 업데이트 하는 것 말고 다른 방법은 없나요 ?
내 활동 <-> 내 통계 왔다갔다 할 때마다 서버 통신하면 비용이 많이 들 것 같아요
Member
Author
There was a problem hiding this comment.
r: onResume 에서 활동 업데이트 하는 것 말고 다른 방법은 없나요 ? 내 활동 <-> 내 통계 왔다갔다 할 때마다 서버 통신하면 비용이 많이 들 것 같아요
이거 이미 날렸슴당
|
|
||
| override fun onResume() { | ||
| super.onResume() | ||
| override fun onStart() { |
Member
There was a problem hiding this comment.
a: 얘는 onResume > onStart 로 변경된 이유가 따로 있나요 ? 궁금
Member
Author
There was a problem hiding this comment.
a: 얘는 onResume > onStart 로 변경된 이유가 따로 있나요 ? 궁금
이거 우테코에서 스터디때 바뀐 코드인데 수정을 안해서 이 부분도 푸쉬된 사항입니다
m6z1
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
Screen_recording_20250503_231937.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴