refactor: 사진소소 1차 QA 반영 #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough이번 변경사항은 피드 생성 화면에서 EditText 스크롤 개선, 이미지 첨부 관련 동적 표시, 업로드 중 로딩 애니메이션 오버레이 추가, 그리고 UI 여백 조정이 포함되어 있습니다. 주요 로직 추가는 모두 액티비티 내부의 private 메서드로 구현되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CreateFeedActivity
participant ViewModel
User->>CreateFeedActivity: EditText에 입력/스크롤 시도
CreateFeedActivity->>CreateFeedActivity: setupCustomScroll()로 내부 스크롤 허용
User->>CreateFeedActivity: 피드 업로드 시작
CreateFeedActivity->>ViewModel: 업로드 상태 변경 요청
ViewModel-->>CreateFeedActivity: uploading = true
CreateFeedActivity->>CreateFeedActivity: 로딩 오버레이 및 애니메이션 표시 (setupLoadingAnimation)
ViewModel-->>CreateFeedActivity: uploading = false
CreateFeedActivity->>CreateFeedActivity: 로딩 오버레이 숨김
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(해당 변경사항에서 이슈 목표와 무관한 기능적 코드 변경은 발견되지 않았습니다.) Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
app/src/main/res/layout/activity_create_feed.xml (1)
321-341: 로딩 오버레이 구현을 개선할 수 있습니다.로딩 오버레이가 잘 구현되었지만, 접근성 향상을 위해 개선할 수 있습니다.
다음 diff를 적용하여 접근성을 개선하세요:
<androidx.constraintlayout.widget.ConstraintLayout android:layout_width="0dp" android:layout_height="0dp" android:background="@color/black_60_99000000" + android:contentDescription="@string/loading_description" + android:focusable="true" app:isVisible="@{viewModel.uploading}" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" tools:visibility="gone"> <ImageView android:id="@+id/iv_create_feed_load" android:layout_width="50dp" android:layout_height="50dp" + android:contentDescription="@string/loading_animation" android:src="@drawable/ic_load_load" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" /> </androidx.constraintlayout.widget.ConstraintLayout>app/src/main/java/com/into/websoso/ui/createFeed/CreateFeedActivity.kt (1)
250-257: ImageLoader 성능 최적화를 고려해보세요.GIF 로딩 구현이 올바르게 되어 있지만, 성능 최적화를 위해 ImageLoader를 lazy property로 만들 수 있습니다.
다음과 같이 개선할 수 있습니다:
+ private val gifImageLoader by lazy { + ImageLoader + .Builder(this) + .components { + add(ImageDecoderDecoder.Factory()) + }.build() + } + private fun setupLoadingAnimation() { - val gifImageLoader = ImageLoader - .Builder(this) - .components { - add(ImageDecoderDecoder.Factory()) - }.build() binding.ivCreateFeedLoad.load(ic_load_load, gifImageLoader) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/src/main/java/com/into/websoso/ui/createFeed/CreateFeedActivity.kt(5 hunks)app/src/main/res/layout/activity_create_feed.xml(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (5)
app/src/main/res/layout/activity_create_feed.xml (2)
110-110: 간격 조정이 적절하게 적용되었습니다.QA 피드백을 반영한 디자인 간격 조정이 일관성 있게 적용되었습니다.
Also applies to: 146-146, 183-183
236-236: 동적 가시성 바인딩이 올바르게 구현되었습니다.첨부된 이미지가 있을 때만 ComposeView가 표시되도록 하는 로직이 정확합니다.
app/src/main/java/com/into/websoso/ui/createFeed/CreateFeedActivity.kt (3)
3-3: 필요한 import 구문들이 적절히 추가되었습니다.커스텀 스크롤과 로딩 애니메이션 구현에 필요한 import들이 올바르게 추가되었습니다.
Also applies to: 7-7, 14-16, 36-36
68-68: 새로운 기능 초기화 메서드 호출이 적절히 추가되었습니다.onCreate()에서 setupCustomScroll()과 setupLoadingAnimation() 메서드 호출이 올바른 위치에 배치되었습니다.
Also applies to: 74-74
97-109: 커스텀 스크롤 구현이 올바르게 작성되었습니다.EditText 내부 스크롤이 부모 뷰의 터치 이벤트 가로채기와 충돌하지 않도록 적절히 처리되었습니다. @SuppressLint 어노테이션 사용도 적절합니다.
s9hn
approved these changes
Jul 7, 2025
| } | ||
|
|
||
| private fun setupLoadingAnimation() { | ||
| val gifImageLoader = ImageLoader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
Screen_recording_20250706_232016.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
Summary by CodeRabbit
신규 기능
스타일
버그 수정