Skip to content

Conversation

@m6z1
Copy link
Member

@m6z1 m6z1 commented Aug 11, 2025

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

  • 내 별점 5.0 일 때 안 보이는 현상 해결
  • 전체 별점이 0.0 으로 보이는 현상 해결

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

Screenshot_20250811_234948

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

Summary by CodeRabbit

  • 신기능
    • 작품 평점에 5.0(만점) 값을 새로 지원합니다.
    • 목록/상세 등 화면에서 평점 표시의 정밀도가 향상되었습니다.
  • 리팩터링
    • 평점 데이터 표현을 단순화하여 UI 전반의 표시 일관성과 유지보수성을 개선했습니다.

@m6z1 m6z1 added 🏹 궁사 명지 웹소소 공주의 은밀한 사냥생활 🔨 [FIX] 버그를 수정합니다. labels Aug 11, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

라이브러리 작품 전체 평점을 Enum 변환 대신 Float로 직통 전달하도록 UI 모델·매퍼·컴포넌트를 변경했고, 도메인 Rating enum에 FIVE(5.0f)를 추가했습니다.

Changes

Cohort / File(s) Summary
Domain Rating 확장
domain/library/.../model/Rating.kt
Enum 상수 FIVE(5.0f) 추가. 기존 from(value: Float) 로직은 그대로이며, 5.0 근사값 매핑 가능.
UI 모델 시그니처 변경
feature/library/.../model/NovelUiModel.kt
NovelUiModel의 novelRating 타입을 NovelRating → Float로 변경(공개 API 변경).
매퍼 정렬
feature/library/.../mapper/NovelMapper.kt
NovelEntity.toUiModel에서 novelRating 변환 제거(NovelRating.from(...) → 원시 Float 전달).
컴포넌트 파이프라인 단순화
feature/library/.../component/LibraryListItem.kt
내부 컴포저블들이 totalRating을 NovelRating → Float로 수용. TotalRatingSection에 Float 직접 전달.

Sequence Diagram(s)

sequenceDiagram
  participant Repo as Repository/Entity
  participant Mapper as NovelMapper
  participant UIModel as NovelUiModel(Float)
  participant UI as LibraryListItem/Composables

  Repo->>Mapper: novelRating(Float)
  Mapper->>UIModel: novelRating(Float) 그대로 매핑
  UIModel->>UI: totalRating(Float) 전달
  UI->>UI: TotalRatingSection(rating = Float)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective Addressed Explanation
서재 작품 전체 별점 0.0으로 보이는 이슈 해결 (#746)

Assessment against linked issues: Out-of-scope changes

(해당 없음)

Poem

별점 토끼가 깡총깡총 숫자를 셈했네,
이젠 0.0이 아닌 진짜 값이 반짝이네! ✨
다섯 별도 꽉 채워 FIVE로 점프! ⭐️
플로트 물결 타고 UI로 슝—
오늘의 서재, 반짝이는 평점으로 쑥쑥! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfcb2f4 and 523a4d6.

📒 Files selected for processing (4)
  • domain/library/src/main/java/com/into/websoso/domain/library/model/Rating.kt (1 hunks)
  • feature/library/src/main/java/com/into/websoso/feature/library/component/LibraryListItem.kt (2 hunks)
  • feature/library/src/main/java/com/into/websoso/feature/library/mapper/NovelMapper.kt (1 hunks)
  • feature/library/src/main/java/com/into/websoso/feature/library/model/NovelUiModel.kt (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/746

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@m6z1 m6z1 merged commit 03e15e7 into develop Aug 11, 2025
2 of 3 checks passed
@m6z1 m6z1 deleted the feat/746 branch August 11, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏹 궁사 명지 웹소소 공주의 은밀한 사냥생활 🔨 [FIX] 버그를 수정합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: 서재 작품 전체 별점 0.0 으로 보이는 이슈 해결

3 participants