feat: 리드미 업데이트 및 ci 수정 #758
Conversation
WalkthroughPR은 CI 워크플로우에서 자동 리뷰어 목록을 4명에서 2명으로 축소하고, README의 기여자 표를 2명 기준으로 업데이트했습니다. 다른 설정과 내용은 변경되지 않았습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks (5 passed)✅ Passed checks (5 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
90-95: 테이블 접근성/마크다운 린트 수정 + 오탈자 교정 제안
- 이미지
alt속성 추가 필요(MD045).- 테이블 전후 공백 라인 필요(MD058).
- "Contributers" 오탈자 → "Contributors".
적용 diff:
-## 👨👩👧👦 Contributers -|<img src="https://avatars.githubusercontent.com/u/114990782?v=4" width="125" />|<img src="https://avatars.githubusercontent.com/u/81347125?v=4" width="125" />| -|:---------:|:---------:| -|👑손명지</br>([MoongChi](https://github.com/m6z1))|김세훈</br>([さんくん~☆](https://github.com/s9hn))| +## 👨👩👧👦 Contributors + +|<img src="https://avatars.githubusercontent.com/u/114990782?v=4" width="125" alt="손명지 아바타" />|<img src="https://avatars.githubusercontent.com/u/81347125?v=4" width="125" alt="김세훈 아바타" />| +|:---------:|:---------:| +|👑손명지</br>([MoongChi](https://github.com/m6z1))|김세훈</br>([さんくん~☆](https://github.com/s9hn))| +
🧹 Nitpick comments (1)
.github/workflows/WSS_PR_auto_assign_and_reviewer.yml (1)
12-12: reviewers 입력 포맷 공백 제거 권장액션 파서에 따라 공백이 포함된
,구분이 오작동할 수 있습니다. 안전하게 공백 없이 지정하거나(또는 액션이 지원한다면 YAML 리스트 사용) 확인 바랍니다.권장 diff:
- reviewers: s9hn, m6z1 + reviewers: s9hn,m6z1또는(액션이 멀티라인 지원 시):
- reviewers: s9hn, m6z1 + reviewers: | + s9hn + m6z1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/WSS_PR_auto_assign_and_reviewer.yml(1 hunks)README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
91-91: Images should have alternate text (alt text)
(MD045, no-alt-text)
91-91: Images should have alternate text (alt text)
(MD045, no-alt-text)
91-91: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
93-93: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
README.md (1)
91-93: README 변경 방향성 적절리뷰어 축소와 기여자 표가 일관되게 반영되었습니다. 추가 우려 없습니다.
| - uses: hkusu/review-assign-action@v1 | ||
| with: | ||
| assignees: ${{ github.actor }} | ||
| reviewers: s9hn, m6z1, junseo511, yeonjeen | ||
| reviewers: s9hn, m6z1 |
There was a problem hiding this comment.
🛠️ Refactor suggestion
서드파티 액션 버전 고정(핀) 권고
@v1 대신 커밋 SHA로 핀 고정하여 서플라이체인 리스크를 줄이세요.
예시 diff(실제 SHA로 교체 필요):
- - uses: hkusu/review-assign-action@v1
+ - uses: hkusu/review-assign-action@<COMMIT_SHA>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - uses: hkusu/review-assign-action@v1 | |
| with: | |
| assignees: ${{ github.actor }} | |
| reviewers: s9hn, m6z1, junseo511, yeonjeen | |
| reviewers: s9hn, m6z1 | |
| - uses: hkusu/review-assign-action@<COMMIT_SHA> | |
| with: | |
| assignees: ${{ github.actor }} | |
| reviewers: s9hn, m6z1 |
🤖 Prompt for AI Agents
.github/workflows/WSS_PR_auto_assign_and_reviewer.yml lines 9-12: the workflow
references a third-party action with a mutable tag
`hkusu/review-assign-action@v1`; replace this with a pinned commit SHA to reduce
supply-chain risk (e.g., `hkusu/review-assign-action@<FULL_COMMIT_SHA>`), update
any other action usages similarly, and verify the SHA points to the intended
release/commit before committing.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
Summary by CodeRabbit