Merged
Conversation
…, backend see apps/verifier/urls.py, apps/verifier/views.py, currently use ngrok for getting webhook from sjtu wj platform
…imestamp, answerid, verification code check and create user session
wj OAuth and account-password login
Register the repo https://github.com/Tech-JI/CourseFront for path frontend chore: submodule Register the repo https://github.com/Tech-JI/CourseFront for path frontend
Use yaml and env for robust and secure configuration
…at login to make linter happy
Misc minor fixes in auth
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive authentication and configuration system for the Django application. It modernizes authentication using a new OAuth flow with questionnaire-based verification while introducing a robust multi-layered configuration system.
Key changes:
- New OAuth authentication system using questionnaire platforms for identity verification
- Robust configuration system supporting YAML, environment variables, and defaults
- Streamlined codebase by removing deprecated Celery, pipeline, and analytics components
Reviewed Changes
Copilot reviewed 32 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/config.py | New configuration class implementing hierarchical config loading with deep merging |
| website/settings.py | Completely refactored to use new config system with modern Django practices |
| website/urls.py | Updated URL patterns to use new auth endpoints and removed legacy routes |
| apps/auth/ | New authentication app implementing OAuth flow with questionnaire verification |
| apps/web/views.py | Refactored to use DRF consistently and removed legacy authentication code |
| apps/web/models/ | Simplified Student model and forms, removed legacy authentication fields |
| pyproject.toml | Updated dependencies to support new auth and config systems |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fix(auth)!: Fix log injection vulnerabilities reported by codeql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.