build: configure pytest-django and add dev dependencies #40

SherryShijiarui · 2026-01-03T23:09:26Z

No description provided.

apps/web/models/course.py

apps/web/models/course_offering.py

A-lexisL

tests should be comprehensive, so more tests are needed. Please arrange them into classes based on API and Authenticated status.
e.g.

class TestCourseListAuthenticated
class TestCourseListNotAuthenticated
class TestCourseDetailAuthenticated
...

A-lexisL · 2026-01-19T02:43:25Z

apps/web/tests/test_auth.py

+        response = base_client.get(url)
+        assert response.status_code == 200
+        # Should be at least 1 due to the 'review' fixture
+        assert response.data["review_count"] >= 1


test should be precise, so use ==1 instead of >=1

A-lexisL · 2026-01-19T02:49:36Z

apps/web/tests/test_course.py

+        response = base_client.get(url)
+
+        assert response.status_code == 200
+        assert response.data["count"] >= 3


same as above

A-lexisL · 2026-01-19T02:52:38Z

apps/web/tests/test_course.py

+        # Check that filtering worked (only 1 course returned)
+        assert response.data["count"] == 1
+
+        # FIX: Check course_code instead of department key


I know that you are making adjustments during developments. But comments are for reviewers and future maintainers, so the Fix: xxx here becomes confusing

A-lexisL · 2026-01-19T02:56:15Z

apps/web/tests/test_course.py

+        assert "results" in response.data
+
+    def test_filter_courses_by_department(self, base_client, course_factory):
+        """Verify filtering courses by department code."""


For now, only filter courses by department code for nonauthenticated user exists. But tests for all the following params are needed for authenticated/nonauthenticated users.

- department (string): Filter by department code (case-insensitive) - code (string): Filter by course code (partial match) - min_quality (integer): Filter by minimum quality score (authenticated only) - min_difficulty (integer): Filter by minimum difficulty score (authenticated only) - sort_by (string): Sort field ("course_code", "review_count"),("quality_score", "difficulty_score")(authenticated only) - sort_order (string): "asc" or "desc" (default: "asc") - page (integer): Page number for pagination

(docstring of CoursesListAPI in apps/web/views.py)

Same for other apis

A-lexisL · 2026-01-19T03:11:18Z

apps/web/tests/factories.py

+    @factory.lazy_attribute
+    def course_code(self):
+        """Generates unique MATH100, PHYS101, etc."""
+        return f"{self.department}{self.number}"


course_code is department+4-digit number+J, e.g. CHEM2110J

apps/web/tests/conftest.py

A-lexisL · 2026-01-19T03:29:36Z

apps/web/tests/test_review.py

+class TestReviewManagement:
+    """
+    Tests for Review management:
+    - Creation with validation (30+ chars, valid term)


30 is not a fixed number but varies according to configs.
Its best to generate comments based on settings.WEB["REVIEW"]["COMMENT_MIN_LENGTH"] (since the content of comments is not important, could use python internal string manipulation methods or faker to generate comments of desired length instead of writing them manually)

A-lexisL · 2026-01-19T03:32:40Z

apps/web/tests/test_review.py

+        url = reverse("user_review_api", kwargs={"review_id": review.id})
+        response = auth_client.delete(url)
+        assert response.status_code == 204
+        assert Review.objects.filter(id=review.id).count() == 0


Missing tests for base_client

apps/web/tests/test_vote.py

A-lexisL · 2026-01-19T03:40:44Z

apps/web/tests/test_course.py

+
+        assert response.status_code == 200
+        # Verify the title matches the fixture-created course
+        assert response.data["course_title"] == course.course_title


base_client and auth_client will receive different response data:

auth_client: full details

base_client: "quality_score" ,"difficulty_score","difficulty_vote","quality_vote","quality_vote_count","difficulty_vote_count" fields are removed(the docstrings for CoursesDetailAPI is not complete)

…ated test

…fix the format of the course code later

…ew.py

…sc and desc) pagnition)

A-lexisL

The tests are comprehensive. But some test cases still need polishing.

A-lexisL · 2026-02-02T06:04:13Z

apps/web/tests/lib_tests/test_terms.py

            term_data
            and term_data.group("year") == "16"
            and term_data.group("term") == "w"
+            and term_data.group("term") == "F"


A-lexisL · 2026-02-02T06:04:52Z

apps/web/tests/conftest.py

+@pytest.fixture
+def department_mixed_courses(db):
+    """Returns a mixed set of courses for filtering/sorting tests."""
+    # Note: Using 'title' to match your original course.py


since title is changed to course_title, this comment is outdated

A-lexisL · 2026-02-02T06:42:55Z

apps/web/tests/test_course.py

+        resp_p1 = auth_client.get(url, {"page": 1})
+
+        assert resp_p1.status_code == 200
+        assert len(resp_p1.data["results"]) == 10


10 is hardcoded.
Its not very necessary to test pagination, as it has nothing to do with data correctness/authentication access

A-lexisL · 2026-02-02T06:45:53Z

apps/web/tests/test_review.py

+            status.HTTP_403_FORBIDDEN,
+        ]
+
+    def test_department_api_empty(self, base_client, db):


This could be removed: department_api is already tested in test_course.py

A-lexisL · 2026-02-02T06:51:57Z

apps/web/tests/test_review.py

+        """5. Verify user can list their own reviews."""
+        response = auth_client.get(personal_reviews_list_url)
+        assert response.status_code == status.HTTP_200_OK
+        assert any(r["id"] == review.id for r in response.data)


should check if the api returns and only returns personal reviews. e.g. review + other_review and the api only returns review

A-lexisL · 2026-02-02T07:04:09Z

apps/web/tests/test_review.py

+
+        ReviewFactory(course=course, professor="UniqueProf", comments="c" * min_len)
+        response = auth_client.get(course_reviews_url, {"q": "UniqueProf"})
+        assert any(r["professor"] == "UniqueProf" for r in response.data)


should be all
Although search review could also match partial UniqueProf in professor/comment, in this case only reviews that ["professor"] == "UniqueProf" would be returned

A-lexisL · 2026-02-02T07:09:35Z

apps/web/tests/test_review.py

+        self, auth_client, personal_review_detail_url, review, valid_review_data
+    ):
+        """9. Verify successful update of user's own review."""
+        valid_review_data["comments"] = "Updated content that is long enough."


min length is according to config. So this comment may not be long enough. Use 'b' * min_len

A-lexisL · 2026-02-02T07:11:24Z

apps/web/tests/test_review.py

+        ]
+        assert Review.objects.filter(id=review.id).exists()
+
+    def test_department_api_sorting(self, base_client, db):


could be removed.

A-lexisL · 2026-02-02T07:13:02Z

apps/web/tests/test_review.py

+    ):
+        """14. Verify PUT fails if required fields (professor) are missing."""
+        response = auth_client.put(
+            personal_review_detail_url, {"comments": "Valid length..."}, format="json"


still min length problem.
Dont know whether 400 is caused by min length or missing fields

A-lexisL · 2026-02-02T07:16:17Z

apps/web/tests/test_review.py

+    ):
+        """19. Verify vote statistics are included in the response."""
+        response = auth_client.get(personal_review_detail_url)
+        assert "kudos_count" in response.data


also test dislike_count

SherryShijiarui added 12 commits January 4, 2026 07:05

build: configure pytest-django and add dev dependencies

1149dab

fix: update factory compatibility

8d3ed21

fix: increase field lengths and update Django+migrations

a3fc806

build: test_auth.py

54059f0

fix: resolve model naming and factory syntax errors

5459ae8

fix: implement robust data factories for course and student

cbd6269

build: test_auth.py test_course.py test_review.py

3ab511e

fix: test_review.py

bcc4148

fix: add more function to test_auth.py and test_course.py

6439b8f

fix: add more function to test_review.py

6a44f11

fix: add more function to test_vote.py

706f8c5

reset to original database

656cb5d

PACHAKUTlQ reviewed Jan 12, 2026

View reviewed changes

apps/web/models/course.py Show resolved Hide resolved

PACHAKUTlQ reviewed Jan 12, 2026

View reviewed changes

apps/web/models/course_offering.py Outdated Show resolved Hide resolved

SherryShijiarui added 3 commits January 12, 2026 22:07

reset to original py

7a3cf02

fix: fix test.review.py

2cff119

fix: push 0012_vote_web_vote_course__b117a9_idx.py

74cb780

A-lexisL requested changes Jan 19, 2026

View reviewed changes

A-lexisL added this to Course Review Jan 19, 2026

github-project-automation bot moved this to Todo in Course Review Jan 19, 2026

A-lexisL moved this from Todo to In Progress in Course Review Jan 19, 2026

liaotian756 and others added 5 commits January 19, 2026 16:32

test: add new vote tests (difficulty, change, cancel) and unauthentic…

088539c

…ated test

add tests(filtering and sorting courses with permission check) TODO: …

bdf5b2e

…fix the format of the course code later

fix: fix course_code in factories.py

8997bda

fix: make test more precise in test_auth.py

38da811

FIX: use the right format of course code

bc0334e

liaotian756 force-pushed the feat/web-view-pytest branch from d40df23 to bc0334e Compare January 20, 2026 01:10

SherryShijiarui added 3 commits January 20, 2026 09:22

fix: make test_auth.py more conprehensive with 0 and multiple cases

23d6f05

build: add more fixture to conftest.py

a314ed8

build: add more fixture to conftest.py

97460ba

SherryShijiarui added 5 commits January 20, 2026 10:47

build: add more fixture to conftest.py and add more test to test_revi…

8d3f870

…ew.py

fix: fix course_title in conftest.py and course code in test_review.py

08bd759

fix: fix test

82b7d1f

build: add base_client in test_review.py and test_vote.py

5aec605

add tests: sort by review_count filter by min_difficulty sort order(a…

fa1f27d

…sc and desc) pagnition)

A-lexisL requested changes Feb 2, 2026

View reviewed changes

delete test: pagnition

5a7a0b1

liaotian756 force-pushed the feat/web-view-pytest branch from f0ba2fa to 5a7a0b1 Compare February 2, 2026 14:41

build: configure pytest-django and add dev dependencies #40

Are you sure you want to change the base?

build: configure pytest-django and add dev dependencies #40

Uh oh!

Conversation

SherryShijiarui commented Jan 3, 2026

Uh oh!

Uh oh!

Uh oh!

A-lexisL left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

A-lexisL left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants