1006 Gross profit wrong

[jcmaggi]

As you can see here the gross profit for 1003 and 1006 should be the same (40%), so something is wrong in the 1006 formula

But remember that 1006 should take in account if the project has a Bond the it need

Here because the bond should be 39.00%

[jcmaggi]

I was not able to conver to a issue with "TechGroupOne.APU.WebApp" because was not on the list and ther was not an option to add that

[TeguSolutions]

Do you think it happened because of the last fix?

[jcmaggi]

may be before the percentage was not good, not remember, but now after you fix the amount, the percentage is craze

[jcmaggi]

Working today I found that 1000-1003 had also the Gross profit value wrong.

This is very strange because i recall to check this and this was OK, but you have the image. The percentage for the 1005 is OK that should be the same on 1003

[TeguSolutions]

Can you confirm, only the 1003 - percentage is wrong?

[jcmaggi]

The percentage for 1003 looks ok some times, the 1006 always wrong but the one for 1005 is ok

[TeguSolutions]

Alright, I try to understand, but I can't see why it is wrong.
Please tell me the formula again.
Or you can review the logic.
It is in the APU.DataV2 project, Entitites / Project_Partial.cs

CalculateGroup1000Item1003_ProjectGrandTotal
CalculateGroup1000Item1005_GrossProfit
CalculateGroup1000Item1006_ProjectGrandTotal

For 1000_1003 the percentage is calculated exactly the same as the normal line items.
For 1005/1006 it's different.

[jcmaggi]

we had this working fine before.

I will let you here the formula, but if you need we do a small meeting and clarify all this again , i understand not easy

1000,1003 Gross profit = ((Sum(all items form group groups 1 to 999, Total Price) + sum(items 001 to 999 group 1000, Total Price) ) - (Sum(all items form group groups 1 to 999, Cost Sub-Total) + sum(items 001 to 999 group 1000, Cost Sub-Total )) / ((Sum(all items form group groups 1 to 999, Total Price) + sum(items 001 to 999 group 1000, Total Price) )

1000,1006 Gross profit = ((Sum(all items form group groups 1 to 999, Total Price) + sum(items 001 to 999 group 1000, Total Price) + (1000,1004)) - (Sum(all items form group groups 1 to 999, Cost Sub-Total) + sum(items 001 to 999 group 1000, Cost Sub-Total ) + (1000,1004)) / ((Sum(all items form group groups 1 to 999, Total Price) + sum(items 001 to 999 group 1000, Total Price) + (1000,1004))

[TeguSolutions]

Okay, thank you, I updated the logic.
I have better numbers now.

For example, without Bond (1000-1004) the 1003/1005/1006 percentages are equal.

With Bond:

Please check it, is it fine now?

[TeguSolutions]

Maybe there is a remaining issue:
1000,1006 Gross profit = ....... (1000,1004) ......
Which value to use for (1000,1004)?
Total Price or Cost SubTotal?

[jcmaggi]

I see on you response that the groos for line (1000,1005) is correct if you have bond or not.
Now the gross for line item 1000,1006 with bond or without bond should be the same as the line (1000, 1005) because at the end is the profit / totalPrice

I see on your code that this is the formula and it looks right:
apu.Sum.GrossTotalPct = (allItemsTotalPrice + bondItemsTotalPrice - (allItemsSubTotalPrice + bondItemsTotalPrice))
/ (allItemsTotalPrice + bondItemsTotalPrice);
apu.Sum.GrossTotalPct *= 100;
but doing the math reverse, you are getting a percentage of 27.26%, if your profit is 383,093.39 and you say it is 27.26 that means that you are dividing by 1,405,189.47 so your “bondItemsTotalPrice” is not bringing the bond number so that is making ((allItemsTotalPrice + bondItemsTotalPrice) = 1,405,189.47 what is wrong it should be 1,441,219.97
Do the math:

apu.Sum.GrossTotalPct = (1,405,189.47 + 36,030.50 - (1,405,189.47 + 36,030.50))
/ (1,405,189.47 + 36,030.50);
apu.Sum.GrossTotalPct *= 100;

apu.Sum.GrossTotalPct = (1,441,219.97- (1,058,126.58))
/ (1,441,219.97);
apu.Sum.GrossTotalPct *= 100;

apu.Sum.GrossTotalPct = (383,093.39))
/ (1,441,219.97);
apu.Sum.GrossTotalPct *= 100;
apu.Sum.GrossTotalPct = 26.58 %
and you are getting 27.26%
So the problem is not in the formula, the problem is on the value of the variables and I think the problem is on the bondItemsTotalPrice that is bringing 0 instead the Bond value

[TeguSolutions]

Alright, basically it is related to my question.
I changed the logic for 1000_1006 to calculate the bond with the TotalExtend instead of the Total.

        //var bondItemsTotalPrice = group1000Item1004_paymentandbonds.Sum(q => q.Sum.Total);
        var bondItemsTotalPrice = group1000Item1004_paymentandbonds.Sum(q => q.Sum.TotalExtend);

It gives the following results:

a, without bond

b, with bond

[jcmaggi]

I see all these now perfect, I will close this to Production