Skip to content

Forge 2.0: pipx re-write#27

Merged
tucamsam merged 17 commits into
TeleTrackingTechnologies:devfrom
mszaf:pipx-variant
Jan 6, 2021
Merged

Forge 2.0: pipx re-write#27
tucamsam merged 17 commits into
TeleTrackingTechnologies:devfrom
mszaf:pipx-variant

Conversation

@mszaf
Copy link
Copy Markdown
Contributor

@mszaf mszaf commented Dec 31, 2020

Forge 2.0

This PR is to refresh forge to work for windows users and solve issues like dependency collisions amongst many plugins
Forge is now a wrapper around pipx, this simplifies nearly all facets of forge 1.0

Issues resolved by this PR

Highlights

  • Now using pipx for plugin management
  • Implemented Halofor progress spinners
  • Added custom exceptions
  • Unknown commands now recognized instead of erroring out
  • Before: forge plugin-name would yield the same as forge - This now properly runs plugin-name with no arguments
  • Added installation of all discovered requirements.txt files from installed plugins
  • Python 3.7-3.9, on Mac + Windows + Linux added to testing workflow
  • Froze requirement versions in setup.py
  • Added type checking into tests

Sample Runs ( Unix | Windows )

forge

Imgur Image

forge -h - Notice installed plugins are injected into this menu

Imgur Image

forge add

Imgur Image
Imgur Image

forge update

Imgur Image
Imgur Image

@mszaf mszaf marked this pull request as ready for review January 4, 2021 14:30
@mszaf
Copy link
Copy Markdown
Contributor Author

mszaf commented Jan 4, 2021

The version of Forge for this PR can be installed using:
pipx install git+https://github.com/mszaf/forge@142aa700aac456404c69e12c9d40ff3dfe31fabc

Comment thread README.md Outdated
```
$ make install
```shell
$ pip3 install tele-forge
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip3 -> pipx

@tucamsam tucamsam merged commit ffd48bd into TeleTrackingTechnologies:dev Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants