Fix PAGImageView setScaleMode(None) not resetting matrix on HarmonyOS #3256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove early return when scaleMode is None in refreshMatrixFromScaleMode(), so that the matrix will be properly reset to identity matrix via ApplyScaleMode() which returns identity matrix for PAGScaleMode::None. This fixes the issue where calling setScaleMode(0) after setScaleMode(2) on PAGImageView would not update the rendering as expected. Fixes: #2914
kevingpqi123
requested review from
Hparty,
domchen and
shlzxjp
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
==========================================
+ Coverage 77.10% 77.24% +0.13%
==========================================
Files 415 415
Lines 22040 22040
Branches 6307 6307
==========================================
+ Hits 16995 17024 +29
+ Misses 3818 3811 -7
+ Partials 1227 1205 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
domchen
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On HarmonyOS, PAGImageView and PAGView behave differently when calling setScaleMode(0):
Related: #2914
Solution
Remove early return when scaleMode is None. ApplyScaleMode() already returns identity matrix for None.