fix(shim): use read_stderr for stderr stream forwarding#191
Merged
Conversation
fslongjin
approved these changes
May 12, 2026
Member
|
Hello, please add DCO to your commit. |
Corrected a bug in the Exec stream forwarding logic where the stderr stream was incorrectly using the stdout read method. This fix ensures that stderr output from containers is properly captured and forwarded to the host. Assisted-by: Antigravity:Gemini-2.0-Flash Signed-off-by: novahe <heqianfly@gmail.com>
novahe
force-pushed
the
fix/exec-stderr-stream
branch
from
0a6653d to
b9f10d5
Compare
Contributor
Author
|
PTAL @fslongjin |
fslongjin
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that commands executed via exec were missing stderr output, and sometimes stdout output was randomly split into the stderr stream.
Investigated and discovered that the forward_stderr logic was incorrectly polling read_stdout instead of read_stderr