Skip to content

chore: update Chinese text to English in cubecli#192

Merged
fslongjin merged 1 commit into
TencentCloud:masterfrom
fslongjin:chore-update-chinese-text-to-english
May 13, 2026
Merged

chore: update Chinese text to English in cubecli#192
fslongjin merged 1 commit into
TencentCloud:masterfrom
fslongjin:chore-update-chinese-text-to-english

Conversation

@fslongjin
Copy link
Copy Markdown
Member

Updated the Usage description for --same flag from Chinese to English in benchrun.go for internationalization consistency.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

Claude finished @fslongjin's task in 2m 11s —— View job


PR Review: chore: update Chinese text to English in cubecli

  • Gather context and read changed files
  • Check DCO compliance
  • Review code changes
  • Post review feedback

DCO Check

The commit 68068cb contains a valid Signed-off-by: jinlong <jinlong@tencent.com> trailer. DCO compliance: PASS.


Summary

This PR translates Chinese Usage strings and error messages to English across 5 CLI command files (4 in CubeMaster, 1 in Cubelet). The changes are purely string translations — no logic changes. Overall this is a good internationalization improvement.

Issues Found

  1. Inconsistent --same flag translationCubeMaster/.../benchrun.go:79 says "Scenario requiring strict concurrent execution" while Cubelet/.../benchrun.go:85 says "Run with strict concurrent synchronization". These describe the same flag and should use the same wording. The Cubelet version is more concise.

  2. Double semicolons in hostid/hostip usage strings — The benchrun.go translations use double semicolons (; ...; ...) which reads awkwardly. Using a period after the second clause would be more natural.

  3. Lost nuance in info.go sandboxid flag — The original Chinese "单意义不大" (specifying both has little significance) is not conveyed in the English translation.

  4. Pre-existing typobenchrun.go:100 has "bussiness" instead of "business" (not introduced by this PR, but worth noting for a follow-up).

What Looks Good

  • All Chinese text in the changed files has been fully translated
  • No remaining Chinese text in the CLI command directories
  • Error messages are also translated (not just usage strings)
  • DCO sign-off is present

Recommendation

Approve with minor suggestions. The translations are functional and the PR achieves its goal. The inline comments suggest optional improvements for consistency and clarity — none are blocking issues.

Comment thread CubeMaster/cmd/cubemastercli/commands/cubebox/benchrun.go Outdated
Comment thread CubeMaster/cmd/cubemastercli/commands/cubebox/benchrun.go Outdated
Comment thread CubeMaster/cmd/cubemastercli/commands/cubebox/benchrun.go Outdated
Comment thread CubeMaster/cmd/cubemastercli/commands/cubebox/info.go Outdated
Comment thread CubeMaster/cmd/cubemastercli/commands/cubebox/list.go Outdated
Updated the Usage description for --same flag from Chinese to English
in benchrun.go for internationalization consistency.

Signed-off-by: jinlong <jinlong@tencent.com>
@fslongjin fslongjin force-pushed the chore-update-chinese-text-to-english branch from 68068cb to 4799ca5 Compare May 13, 2026 02:44
@fslongjin fslongjin merged commit f37358c into TencentCloud:master May 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant